fix #626, add AMD module format and make it default

test/browser/language_tests.js

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-(function() {
+define(['dart_sdk', 'async_helper', 'unittest', 'require'],
+      function(dart_sdk, async_helper, unittest, require) {
   'use strict';
 
-  let dart_sdk = dart_library.import('dart_sdk');
+  async_helper = async_helper.async_helper;
+
   dart_sdk._isolate_helper.startRootIsolate(function() {}, []);
-  let async_helper = dart_library.import('async_helper').async_helper;
-  let unittest = dart_library.import('unittest');
   let html_config = unittest.html_config;
   // Test attributes are a list of strings, or a string for a single
   // attribute. Valid attributes are:
   //
   //   'notyetstrong' - test is not yet strong mode safe
   //   'skip' - don't run the test
   //   'fail' - test fails
   //   'timeout' - test times out
   //   'slow' - use 5s timeout instead of default 2s.
   //   'helper'  - not a test, used by other tests.
@@ skipping 2497 matching lines @@
       'chunked_conversion_utf84_test': skip_timeout,
       'chunked_conversion_utf88_test': skip_timeout,
       'chunked_conversion_utf8_test': skip_timeout,
 
       'chunked_conversion1_test': notyetstrong,
 
       'encoding_test': skip_timeout,
 
       // TODO(jmesserly): this is in an inconsistent state between our old and
       // newer SDKs.
-      'html_escape_test': skip_fail,
-
-      // TODO(jmesserly): seems to fail or pass based on SDK version?
       'html_escape_test': ['skip'],
 
       // TODO(rnystrom): If this test is enabled, karma gets confused and
       // disconnects randomly.
       'json_lib_test': skip_fail,
 
       'json_utf8_chunk_test': skip_timeout,
 
       // TODO(rnystrom): Strong mode cast failure.
       'line_splitter_test': fail,
@@ skipping 194 matching lines @@
     },
   };
 
   function countMatches(text, regex) {
     let matches = text.match(regex);
     return matches ? matches.length : 0;
   }
 
   let unittest_tests = [];
 
-  let languageTestPattern = new RegExp('(.*)/([^/]*_test[^/]*)');
+  let languageTestPattern =
+      new RegExp('gen/codegen_output/(.*)/([^/]*_test[^/]*)');
   html_config.useHtmlConfiguration();
   // We need to let Dart unittest control when tests are run not mocha.
   // mocha.allowUncaught(true);
   let dartUnittestsLeft = 0;
-  for (let testFile of dart_library.libraries()) {
+  for (let testFile of allTestFiles) {
     let match = languageTestPattern.exec(testFile);
     if (match != null) {
       let status_group = match[1]
       let name = match[2];
       let module = match[0];
 
       let status = all_status[status_group];
       if (status == null) throw "No status for '" + status_group + "'";
 
       let expectation = status[name];
       if (expectation == null) expectation = [];
       if (typeof expectation == 'string') expectation = [expectation];
-      function has(tag) {
-        return expectation.indexOf(tag) >= 0;
-      }
+      let has = (tag) => expectation.indexOf(tag) >= 0;
 
       if (has('helper')) {
         // These are not top-level tests.  They are used by other tests.
         continue;
       }
 
       if (has('skip')) {
         let why = 'for unknown reason';
         if (has('timeout')) why = 'known timeout';
         if (has('fail')) why = 'known failure';
         console.debug('Skipping ' + why + ': ' + name);
         continue;
       }
 
       // A few tests are special because they use package:unittest.
       // We run them below.
       if (has('unittest')) {
         unittest_tests.push(() => {
           console.log('Running unittest test ' + testFile);
-          dart_library.import(module)[name].main();
+          require(module)[name].main();
         });
         continue;
       }
 
-      function protect(f) {  // Returns the exception, or `null`.
+      let protect = (f) => {  // Returns the exception, or `null`.
         try {
           f();
           return null;
         } catch (e) {
           return e;
         }
-      }
+      };
 
       test(name, function(done) { // 'function' to allow `this.timeout`.
         async_helper.asyncTestInitialize(done);
         console.debug('Running test:  ' + name);
 
-        let mainLibrary = dart_library.import(module)[name];
+        let mainLibrary = require(module)[name];
         let negative = /negative_test/.test(name);
         if (has('slow')) this.timeout(10000);
         if (has('notyetstrong')) {
           let e = protect(mainLibrary.main);
           if (e == null) {
               throw new Error(
                   "test marked as 'notyetstrong' due to " +
                   "strong mode errors, but passed");
           } else if (!(e instanceof Error) ||
                      !e.message.startsWith("DDC Compilation Error:")) {
@@ skipping 26 matching lines @@
       });
     }
   }
 
   let mochaOnError;
   // We run these tests in a mocha test wrapper to avoid the confusing failure
   // case of dart unittests being interleaved with mocha tests.
   // In practice we are really just suppressing all mocha test behavior while
   // Dart unittests run and then re-enabling it when the dart tests complete.
   test('run all dart unittests', function(done) { // 'function' to allow `this.timeout`
+    if (unittest_tests.length == 0) return done();
+
     this.timeout(100000000);
     this.enableTimeouts(false);
     // Suppress mocha on-error handling because it will mess up unittests.
     mochaOnError = window.onerror;
     window.onerror = function(err, url, line) {
       console.error(err, url, line);
     };
     window.addEventListener('message', (event) => {
       if (event.data == 'unittest-suite-done') {
         window.console.log("Done running unittests");
@@ skipping 20 matching lines @@
     });
 
     for (let action of unittest_tests) {
       try {
         action();
       } catch (e) {
         console.error("Caught error tying to setup test:", e);
       }
     }
   });
-})();
+});