Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2249183003: [Remoting Android] Adjust feedback animation radius (Closed)

Created:
4 years, 4 months ago by Yuwei
Modified:
4 years, 4 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Adjust feedback animation radius This CL increases the maximum radius of the feedback animation so that the feedback is more visible. BUG=638315 Committed: https://crrev.com/f2a08a8eb0b8542f9f4fb6d9385bc6a3e4b8a0ac Cr-Commit-Position: refs/heads/master@{#412907}

Patch Set 1 #

Patch Set 2 : Change only the dp's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M remoting/android/java/res/values/dimens.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Yuwei
ptal To further make it more visible, I will also try to adjust the radius/transparancy-time ...
4 years, 4 months ago (2016-08-16 21:40:08 UTC) #2
joedow
I'm not sure increasing the longpress duration is a good idea. Longpress already seems a ...
4 years, 4 months ago (2016-08-17 16:53:32 UTC) #3
Yuwei
On 2016/08/17 16:53:32, joedow wrote: > I'm not sure increasing the longpress duration is a ...
4 years, 4 months ago (2016-08-17 17:21:48 UTC) #4
Yuwei
On 2016/08/17 17:21:48, Yuwei wrote: > On 2016/08/17 16:53:32, joedow wrote: > > I'm not ...
4 years, 4 months ago (2016-08-18 01:42:25 UTC) #5
Yuwei
Just dropped the change for long press duration. 220 ms is enough for long press ...
4 years, 4 months ago (2016-08-18 18:27:46 UTC) #7
joedow
lgtm
4 years, 4 months ago (2016-08-18 18:30:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249183003/20001
4 years, 4 months ago (2016-08-18 18:33:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 19:15:20 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 19:18:26 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2a08a8eb0b8542f9f4fb6d9385bc6a3e4b8a0ac
Cr-Commit-Position: refs/heads/master@{#412907}

Powered by Google App Engine
This is Rietveld 408576698