[Remoting Android] Adjust feedback animation radius

[Remoting Android] Adjust feedback animation radius

This CL increases the maximum radius of the feedback animation so that the feedback is more visible.

BUG=638315
Committed: https://crrev.com/f2a08a8eb0b8542f9f4fb6d9385bc6a3e4b8a0ac
Cr-Commit-Position: refs/heads/master@{#412907}

[Yuwei, 2016-08-16 21:40:08]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org

[Yuwei, 2016-08-16 21:40:08]

ptal

To further make it more visible, I will also try to adjust the
radius/transparancy-time functions and the texture pattern after this CL.

Thanks!

[joedow, 2016-08-17 16:53:32]

I'm not sure increasing the longpress duration is a good idea.  Longpress
already seems a bit slow so doubling the amount of time until the user sees the
feedback (since the animation starts under the user's finger and expands
outward) will be an improvement.

Perhaps I can take a look at the running code later today and give it a try.

I think increasing the dp is a good change though.

[Yuwei, 2016-08-17 17:21:48]

On 2016/08/17 16:53:32, joedow wrote:
> I'm not sure increasing the longpress duration is a good idea.  Longpress
> already seems a bit slow so doubling the amount of time until the user sees
the
> feedback (since the animation starts under the user's finger and expands
> outward) will be an improvement.

Yes. Doubling the duration doesn't quite solve the longpress problem as long as
the size increases over time. I just try to increase the amount of time so that
the animation looks less abrupt.

> Perhaps I can take a look at the running code later today and give it a try.

Sure. I can hold off the change of duration if it doesn't look good.

> I think increasing the dp is a good change though.

[Yuwei, 2016-08-18 01:42:25]

On 2016/08/17 17:21:48, Yuwei wrote:
> On 2016/08/17 16:53:32, joedow wrote:
> > I'm not sure increasing the longpress duration is a good idea.  Longpress
> > already seems a bit slow so doubling the amount of time until the user sees
> the
> > feedback (since the animation starts under the user's finger and expands
> > outward) will be an improvement.
> 
> Yes. Doubling the duration doesn't quite solve the longpress problem as long
as
> the size increases over time. I just try to increase the amount of time so
that
> the animation looks less abrupt.
> 
> > Perhaps I can take a look at the running code later today and give it a try.
> 
> Sure. I can hold off the change of duration if it doesn't look good.
> 
> > I think increasing the dp is a good change though.

Hmm... Looks like I can still get good visibility by just using 220ms as the
duration for long press. The trick is to use a concave-down function like this:

radius = sqrt(1 - progress^2) * max_radius, 0<= progress <= 1

Then the larger the circle is, the longer it will stay...

[Yuwei, 2016-08-18 18:26:24]

Description was changed from

==========
[Remoting Android] Adjust feedback animation radius and duration

This CL increases the maximum radius of the feedback animation and make the
duration of the hold-and-press animation longer so that the feedback is more
visible.

BUG=638315
==========

to

==========
[Remoting Android] Adjust feedback animation radius

This CL increases the maximum radius of the feedback animation so that the
feedback is more visible.

BUG=638315
==========

[Yuwei, 2016-08-18 18:27:46]

Just dropped the change for long press duration. 220 ms is enough for long press
animation as long as we have a good radius-time function.

[joedow, 2016-08-18 18:30:28]

lgtm

[Yuwei, 2016-08-18 18:33:25]

The CQ bit was checked by yuweih@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:33:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 19:15:18]

Description was changed from

==========
[Remoting Android] Adjust feedback animation radius

This CL increases the maximum radius of the feedback animation so that the
feedback is more visible.

BUG=638315
==========

to

==========
[Remoting Android] Adjust feedback animation radius

This CL increases the maximum radius of the feedback animation so that the
feedback is more visible.

BUG=638315
==========

[commit-bot: I haz the power, 2016-08-18 19:15:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 19:18:25]

Description was changed from

==========
[Remoting Android] Adjust feedback animation radius

This CL increases the maximum radius of the feedback animation so that the
feedback is more visible.

BUG=638315
==========

to

==========
[Remoting Android] Adjust feedback animation radius

This CL increases the maximum radius of the feedback animation so that the
feedback is more visible.

BUG=638315

Committed: https://crrev.com/f2a08a8eb0b8542f9f4fb6d9385bc6a3e4b8a0ac
Cr-Commit-Position: refs/heads/master@{#412907}
==========

[commit-bot: I haz the power, 2016-08-18 19:18:26]

Patchset 2 (id:??) landed as
https://crrev.com/f2a08a8eb0b8542f9f4fb6d9385bc6a3e4b8a0ac
Cr-Commit-Position: refs/heads/master@{#412907}