content/browser/shared_worker/worker_document_set.h - Issue 2249173003: Removes the references to shared workers from the all documents in being deleted frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/shared_worker/worker_document_set.h

Issue 2249173003: Removes the references to shared workers from the all documents in being deleted frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated nhiroki's comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/shared_worker/shared_worker_service_impl.cc ('k') | content/browser/shared_worker/worker_document_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/shared_worker/worker_document_set.h

diff --git a/content/browser/shared_worker/worker_document_set.h b/content/browser/shared_worker/worker_document_set.h

index 34f391f9b647ee6a98baedd76585ce5791f956d4..08af06b5664bc2675cef1bd2a33feaa87579a84a 100644

--- a/content/browser/shared_worker/worker_document_set.h

+++ b/content/browser/shared_worker/worker_document_set.h

@@ -75,6 +75,10 @@ class WorkerDocumentSet : public base::RefCounted<WorkerDocumentSet> {

// from a worker's document set.

void RemoveAll(BrowserMessageFilter* parent);

+ // Invoked when a render frame is deleted, to remove all associated documents

+ // from a worker's document set.

+ void RemoveRenderFrame(int render_process_id, int render_frame_id);

bool IsEmpty() const { return document_set_.empty(); }

// Define a typedef for convenience here when declaring iterators, etc.