Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2249163007: Revert of Roll clang 277962:278861 (Closed)

Created:
4 years, 4 months ago by Guido Urdaneta
Modified:
4 years, 4 months ago
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org, inferno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll clang 277962:278861 (patchset #5 id:80001 of https://codereview.chromium.org/2241413003/ ) Reason for revert: This is suspect of breaking Mac 10.9 builder. See https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/28850 Sample logs: Retrying 1 test (retry #1) [0817/224954:ERROR:kill_posix.cc(84)] Unable to terminate process group 8687: No such process [ RUN ] ThreadTest.StartWithOptions_StackSize [2060/2060] ThreadTest.StartWithOptions_StackSize (CRASHED) Retrying 1 test (retry #2) [0817/224955:ERROR:kill_posix.cc(84)] Unable to terminate process group 8688: No such process [ RUN ] ThreadTest.StartWithOptions_StackSize [2061/2061] ThreadTest.StartWithOptions_StackSize (CRASHED) Retrying 1 test (retry #3) [0817/224955:ERROR:kill_posix.cc(84)] Unable to terminate process group 8689: No such process [ RUN ] ThreadTest.StartWithOptions_StackSize [2062/2062] ThreadTest.StartWithOptions_StackSize (CRASHED) 1 test crashed: ThreadTest.StartWithOptions_StackSize (../../base/threading/thread_unittest.cc:135) Tests took 21 seconds. Additional test environment: CHROME_DEVEL_SANDBOX=/opt/chromium/chrome_sandbox LANG=en_US.UTF-8 Command: ./base_unittests --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-summary-output=/b/swarm_slave/w/ionk6XHB/output.json Original issue's description: > Roll clang 277962:278861 > > BUG=636558, 637866 > > Committed: https://crrev.com/29ecb32ba7b5ca183782c5f5d2b7a1ae23309edb > Cr-Commit-Position: refs/heads/master@{#412745} TBR=rnk@chromium.org,dcheng@chromium.org,dpranke@chromium.org,inferno@chromium.org,hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=636558, 637866 Committed: https://crrev.com/92c4889905b14456f84a4631eafb168328b5f8a5 Cr-Commit-Position: refs/heads/master@{#412785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M base/threading/thread_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +6 lines, -3 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Guido Urdaneta
Created Revert of Roll clang 277962:278861
4 years, 4 months ago (2016-08-18 10:13:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249163007/1
4 years, 4 months ago (2016-08-18 10:14:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 10:14:55 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/92c4889905b14456f84a4631eafb168328b5f8a5 Cr-Commit-Position: refs/heads/master@{#412785}
4 years, 4 months ago (2016-08-18 10:16:40 UTC) #7
Dirk Pranke
4 years, 4 months ago (2016-08-18 16:57:59 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698