Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2249153002: Revert of [Interpreter] Introduce InterpreterCompilationJob (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@offheap_peekhole
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Introduce InterpreterCompilationJob (patchset #7 id:140001 of https://codereview.chromium.org/2240463002/ ) Reason for revert: Failing on Win64 bot: https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/12061/steps/Check/logs/regress-635429 Original issue's description: > [Interpreter] Introduce InterpreterCompilationJob > > Adds InterpreterCompilationJob as a sub-class of > CompilationJob, to enable off-thread bytecode > generation. Currently only used in > Interpreter::MakeBytecode. > > As part of this change, CompilationJob is modified > to make it less specific to optimized compilation, > renaming the phases as follows: > - CreateGraph -> PrepareJob > - OptimizeGraph -> ExecuteJob > - GenerateCode -> FinalizeJob > > RegisterWeakObjectsInOptimizedCode is also moved out > of CompilationJob and instead becomes a static function > on Compiler. > > BUG=v8:5203 > > Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc > Cr-Commit-Position: refs/heads/master@{#38662} TBR=mstarzinger@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203 Committed: https://crrev.com/ce65e1059715dbcafef68b3d4097afc031eaa998 Cr-Commit-Position: refs/heads/master@{#38663}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -217 lines) Patch
M src/compiler.h View 1 chunk +42 lines, -66 lines 0 comments Download
M src/compiler.cc View 8 chunks +64 lines, -64 lines 0 comments Download
M src/compiler-dispatcher/optimizing-compile-dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 7 chunks +14 lines, -15 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/lithium-codegen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.cc View 3 chunks +14 lines, -54 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmcilroy
Created Revert of [Interpreter] Introduce InterpreterCompilationJob
4 years, 4 months ago (2016-08-16 15:06:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249153002/1
4 years, 4 months ago (2016-08-16 15:06:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 15:06:39 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 15:07:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce65e1059715dbcafef68b3d4097afc031eaa998
Cr-Commit-Position: refs/heads/master@{#38663}

Powered by Google App Engine
This is Rietveld 408576698