Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 224913004: Re-add the CQ directory to chrome/trunk/tools. (Closed)

Created:
6 years, 8 months ago by agable
Modified:
6 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Re-add the CQ directory to chrome/trunk/tools. This directory is still pulled by DEPS and is in official Buildspecs. Re-add it for now until we can remove it from all of those. TBR=maruel@chromium.org,cmp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A commit-queue/placeholder.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
agable
Committed patchset #1 manually as r261659 (presubmit successful).
6 years, 8 months ago (2014-04-04 03:57:25 UTC) #1
M-A Ruel
On 2014/04/04 03:57:25, agable wrote: > Committed patchset #1 manually as r261659 (presubmit successful). Hey, ...
6 years, 8 months ago (2014-04-04 13:11:39 UTC) #2
agable
On 2014/04/04 13:11:39, M-A Ruel wrote: > On 2014/04/04 03:57:25, agable wrote: > > Committed ...
6 years, 8 months ago (2014-04-04 16:06:21 UTC) #3
mmoss
6 years, 8 months ago (2014-04-25 15:22:56 UTC) #4
Message was sent while issue was closed.
FYI, I think the only place this is referenced is
svn://svn.chromium.org/chrome/trunk/tools/build/DEPS. It was added years ago,
and I don't know of anything that actually cares about it (or cares enough to
not be broken by it just having a placeholder file now). I'm quite sure it was
never important to the official buildspecs, which just bring it in because it's
there, not because they use it. Probably should just be removed.

Powered by Google App Engine
This is Rietveld 408576698