Issue 22491002: MIPS: Fix Sunspider 1.0/crypto-aes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22491002: MIPS: Fix Sunspider 1.0/crypto-aes. (Closed)

Created:
7 years, 4 months ago by palfia

Modified:
7 years, 4 months ago

Reviewers:
kisg, Paul Lind, kilvadyb, danno, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Fix Sunspider 1.0/crypto-aes. * This makes sure that DoModI calculates correct result even when the left register is the same as the result register. * Microoptmization: it generates smaller code when left and result are different registers. TEST=benchmarks/sunspider/crypto-aes.js BUG= Committed: https://code.google.com/p/v8/source/detail?r=16085

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -12 lines)			Patch
	M	src/mips/lithium-codegen-mips.cc	View		3 chunks	+6 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM. Code is more readable now with this refactoring, thanks.

7 years, 4 months ago (2013-08-06 23:12:17 UTC) #2

Message was sent while issue was closed.

Committed manually as r16085 (presubmit successful).

Expand Messages | Collapse Messages