Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2249083002: Reinstate CDATASection (it's back in the spec) (Closed)

Created:
4 years, 4 months ago by foolip
Modified:
4 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reinstate CDATASection (it's back in the spec) The use counter for createCDATASection was useful: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27386 Now CDATASection is back in the spec: https://github.com/whatwg/dom/pull BUG=437205 R=tkent@chromium.org Committed: https://crrev.com/dd2fe5358c3b1c73d43f9833218f5b9b676eb65c Cr-Commit-Position: refs/heads/master@{#412377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/CDATASection.idl View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/NodeFilter.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
foolip
4 years, 4 months ago (2016-08-16 12:11:49 UTC) #1
tkent
lgtm
4 years, 4 months ago (2016-08-16 23:36:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249083002/1
4 years, 4 months ago (2016-08-16 23:37:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 23:42:34 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 23:44:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd2fe5358c3b1c73d43f9833218f5b9b676eb65c
Cr-Commit-Position: refs/heads/master@{#412377}

Powered by Google App Engine
This is Rietveld 408576698