Eagerly update the unichar to glyphID mapping.

Eagerly update the unichar to glyphID mapping.

In addition, some small cleanups.

BUG=chromium:635005
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249063005

Committed: https://skia.googlesource.com/skia/+/1ae57b37bd718418f564e13675b5cfebe499f7db

[herb_g, 2016-08-17 15:48:49]

Description was changed from

==========
Eagerly update the unichar to glyphID mapping.

BUG=635005
==========

to

==========
Eagerly update the unichar to glyphID mapping.

BUG=635005
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249063005
==========

[herb_g, 2016-08-17 15:49:52]

Description was changed from

==========
Eagerly update the unichar to glyphID mapping.

BUG=635005
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249063005
==========

to

==========
Eagerly update the unichar to glyphID mapping.

In addition, some small cleanups.

BUG=635005
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249063005
==========

[herb_g, 2016-08-17 15:49:52]

herb@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2016-08-17 17:54:57]

Description was changed from

==========
Eagerly update the unichar to glyphID mapping.

In addition, some small cleanups.

BUG=635005
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249063005
==========

to

==========
Eagerly update the unichar to glyphID mapping.

In addition, some small cleanups.

BUG=chromium:635005
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249063005
==========

[bungeman-skia, 2016-08-17 17:59:44]

https://codereview.chromium.org/2249063005/diff/1/src/core/SkGlyphCache.cpp
File src/core/SkGlyphCache.cpp (right):

https://codereview.chromium.org/2249063005/diff/1/src/core/SkGlyphCache.cpp#n...
src/core/SkGlyphCache.cpp:102: rec->fPackedUnicharID = SkGlyph::MakeID(glyphID);
I am confused, shouldn't this be

rec->fPackedUnicharD = packedUnicharID;
rec->fPackedGlyphD = SkGlyph::MakeID(glyphID);

it looks like this is setting just the unicharID to a glyphID?

[herb_g, 2016-08-17 19:25:48]

What was I thinking?

[herb_g, 2016-08-17 19:26:48]

https://codereview.chromium.org/2249063005/diff/1/src/core/SkGlyphCache.cpp
File src/core/SkGlyphCache.cpp (right):

https://codereview.chromium.org/2249063005/diff/1/src/core/SkGlyphCache.cpp#n...
src/core/SkGlyphCache.cpp:102: rec->fPackedUnicharID = SkGlyph::MakeID(glyphID);
On 2016/08/17 17:59:44, bungeman-skia wrote:
> I am confused, shouldn't this be
> 
> rec->fPackedUnicharD = packedUnicharID;
> rec->fPackedGlyphD = SkGlyph::MakeID(glyphID);
> 
> it looks like this is setting just the unicharID to a glyphID?

Fixed.

[bungeman-skia, 2016-08-17 19:28:17]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2016-08-17 19:28:17]

lgtm

[commit-bot: I haz the power, 2016-08-17 19:28:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 20:52:12]

Description was changed from

==========
Eagerly update the unichar to glyphID mapping.

In addition, some small cleanups.

BUG=chromium:635005
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249063005
==========

to

==========
Eagerly update the unichar to glyphID mapping.

In addition, some small cleanups.

BUG=chromium:635005
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249063005

Committed:
https://skia.googlesource.com/skia/+/1ae57b37bd718418f564e13675b5cfebe499f7db
==========

[commit-bot: I haz the power, 2016-08-17 20:52:13]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1ae57b37bd718418f564e13675b5cfebe499f7db