Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2249063005: Eagerly update the unichar to glyphID mapping. (Closed)

Created:
4 years, 4 months ago by herb_g
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Eagerly update the unichar to glyphID mapping. In addition, some small cleanups. BUG=chromium:635005 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2249063005 Committed: https://skia.googlesource.com/skia/+/1ae57b37bd718418f564e13675b5cfebe499f7db

Patch Set 1 #

Total comments: 2

Patch Set 2 : What was I thinking? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/core/SkGlyphCache.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
herb_g
4 years, 4 months ago (2016-08-17 15:50:53 UTC) #4
bungeman-skia
https://codereview.chromium.org/2249063005/diff/1/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/2249063005/diff/1/src/core/SkGlyphCache.cpp#newcode102 src/core/SkGlyphCache.cpp:102: rec->fPackedUnicharID = SkGlyph::MakeID(glyphID); I am confused, shouldn't this be ...
4 years, 4 months ago (2016-08-17 17:59:44 UTC) #6
herb_g
What was I thinking?
4 years, 4 months ago (2016-08-17 19:25:48 UTC) #7
herb_g
https://codereview.chromium.org/2249063005/diff/1/src/core/SkGlyphCache.cpp File src/core/SkGlyphCache.cpp (right): https://codereview.chromium.org/2249063005/diff/1/src/core/SkGlyphCache.cpp#newcode102 src/core/SkGlyphCache.cpp:102: rec->fPackedUnicharID = SkGlyph::MakeID(glyphID); On 2016/08/17 17:59:44, bungeman-skia wrote: > ...
4 years, 4 months ago (2016-08-17 19:26:48 UTC) #8
bungeman-skia
lgtm
4 years, 4 months ago (2016-08-17 19:28:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249063005/20001
4 years, 4 months ago (2016-08-17 19:28:31 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 20:52:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1ae57b37bd718418f564e13675b5cfebe499f7db

Powered by Google App Engine
This is Rietveld 408576698