Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2249033003: [SVGDom] Add <circle>, <ellipse> support (Closed)

Created:
4 years, 4 months ago by f(malita)
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10

Patch Set 2 : review #

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGAttribute.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
A experimental/svg/model/SkSVGCircle.h View 1 chunk +38 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGCircle.cpp View 1 chunk +58 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGDOM.cpp View 3 chunks +7 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGEllipse.h View 1 chunk +40 lines, -0 lines 0 comments Download
A experimental/svg/model/SkSVGEllipse.cpp View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M experimental/svg/model/SkSVGNode.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/svg.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
f(malita)
4 years, 4 months ago (2016-08-16 19:48:19 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/2249033003/diff/1/experimental/svg/model/SkSVGAttribute.h File experimental/svg/model/SkSVGAttribute.h (right): https://codereview.chromium.org/2249033003/diff/1/experimental/svg/model/SkSVGAttribute.h#newcode16 experimental/svg/model/SkSVGAttribute.h:16: enum class SkSVGAttribute { // circle & ellipse ...
4 years, 4 months ago (2016-08-16 22:02:37 UTC) #9
f(malita)
https://codereview.chromium.org/2249033003/diff/1/experimental/svg/model/SkSVGAttribute.h File experimental/svg/model/SkSVGAttribute.h (right): https://codereview.chromium.org/2249033003/diff/1/experimental/svg/model/SkSVGAttribute.h#newcode16 experimental/svg/model/SkSVGAttribute.h:16: enum class SkSVGAttribute { On 2016/08/16 22:02:37, robertphillips wrote: ...
4 years, 4 months ago (2016-08-16 22:18:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249033003/40001
4 years, 4 months ago (2016-08-16 22:18:19 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 22:38:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/dc4c2a9fb7210925df7cc5c142b691e6c817ca77

Powered by Google App Engine
This is Rietveld 408576698