src/objects.cc - Issue 224903023: Fix invalid local property lookup for transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 224903023: Fix invalid local property lookup for transitions. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Whitespace fix Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index d370e123380ba1d5a3cf2ab23005c94316621976..d24af57770cdede69d25255b297e051a62e7c693 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -4228,8 +4228,8 @@ MaybeHandle<Object> JSObject::SetLocalPropertyIgnoreAttributes(

name, value, attributes, value_type, mode, extensibility_check);

}

- if (lookup.IsFound() &&

- (lookup.type() == INTERCEPTOR || lookup.type() == CALLBACKS)) {

+ if (lookup.IsInterceptor() ||

+ (lookup.IsDescriptorOrDictionary() && lookup.type() == CALLBACKS)) {

object->LocalLookupRealNamedProperty(*name, &lookup);

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-361025.js » ('j') | no next file with comments »