Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 224903012: Don't try to render color fonts using distance fields (Closed)

Created:
6 years, 8 months ago by jvanverth1
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Don't try to render color fonts using distance fields. Adds detection of ARGB mask format, which is only used for color fonts. BUG=skia:2173 Committed: http://code.google.com/p/skia/source/detail?r=14098

Patch Set 1 #

Patch Set 2 : Switch to not render color fonts #

Patch Set 3 : Go back to using ShouldDrawTextAsPaths #

Total comments: 3

Patch Set 4 : Add comments; windows compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M src/core/SkScalerContext.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 3 1 chunk +26 lines, -5 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 2 3 1 chunk +3 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvanverth1
I'm keying off of the ARGB mask format to render color fonts when using bitmaps, ...
6 years, 8 months ago (2014-04-07 19:56:03 UTC) #1
bsalomon
On 2014/04/07 19:56:03, JimVV wrote: > I'm keying off of the ARGB mask format to ...
6 years, 8 months ago (2014-04-07 20:32:46 UTC) #2
robertphillips
some comment suggestions https://codereview.chromium.org/224903012/diff/40001/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (right): https://codereview.chromium.org/224903012/diff/40001/src/gpu/GrDistanceFieldTextContext.cpp#newcode61 src/gpu/GrDistanceFieldTextContext.cpp:61: // DF fonts can't predice what ...
6 years, 8 months ago (2014-04-08 12:19:42 UTC) #3
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 8 months ago (2014-04-08 19:49:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/224903012/60001
6 years, 8 months ago (2014-04-08 19:49:22 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 20:14:49 UTC) #6
Message was sent while issue was closed.
Change committed as 14098

Powered by Google App Engine
This is Rietveld 408576698