Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 224903005: Reland "create a function call IC" (Closed)

Created:
6 years, 8 months ago by mvstanton
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Reland of https://codereview.chromium.org/172523002/ Fixed 1) Missing line in x64 port. 2) GcStress found a logic error in the IC miss handler. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20516

Patch Set 1 #

Patch Set 2 : Performance patches from Tuesday. #

Patch Set 3 : x64 webkit and GCSTRESS fixes. #

Total comments: 3

Patch Set 4 : Comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1185 lines, -562 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 5 chunks +147 lines, -41 lines 0 comments Download
M src/arm/debug-arm.cc View 3 chunks +11 lines, -20 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 9 chunks +26 lines, -61 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 chunks +161 lines, -46 lines 0 comments Download
M src/arm64/debug-arm64.cc View 3 chunks +11 lines, -20 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 9 chunks +25 lines, -62 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M src/code-stubs.h View 1 7 chunks +57 lines, -15 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/debug.h View 3 chunks +1 line, -4 lines 0 comments Download
M src/debug.cc View 1 2 3 7 chunks +18 lines, -11 lines 0 comments Download
M src/full-codegen.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 5 chunks +150 lines, -39 lines 0 comments Download
M src/ia32/debug-ia32.cc View 3 chunks +12 lines, -21 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 10 chunks +26 lines, -63 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.h View 1 3 chunks +127 lines, -0 lines 0 comments Download
M src/ic.cc View 1 2 3 7 chunks +165 lines, -3 lines 0 comments Download
M src/log.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 3 3 chunks +3 lines, -1 line 0 comments Download
M src/objects-visiting-inl.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/v8globals.h View 2 chunks +7 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 6 chunks +152 lines, -41 lines 0 comments Download
M src/x64/debug-x64.cc View 3 chunks +12 lines, -21 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 9 chunks +27 lines, -63 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Toon, Here is the update to reland the earlier CL. Thanks, --Michael
6 years, 8 months ago (2014-04-04 09:08:29 UTC) #1
Toon Verwaest
This problem shows how much of a bad idea it is to always clear the ...
6 years, 8 months ago (2014-04-04 09:24:46 UTC) #2
mvstanton
6 years, 8 months ago (2014-04-04 13:58:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r20516 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698