Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 2249005: AppCache: Use a dedicated thread for the disk cache. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by rvargas (out until 9-8)
Modified:
4 years, 2 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

AppCache: Use a dedicated thread for the disk cache. BUG=26730 TEST=current tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49111

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 7

Patch Set 6 : Bound to IO thread #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -364 lines) Patch
M chrome/browser/appcache/chrome_appcache_service.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_disk_cache.h View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M webkit/appcache/appcache_disk_cache.cc View 1 2 3 4 5 2 chunks +6 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_service.h View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M webkit/appcache/appcache_service.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_storage_impl.h View 1 2 3 4 5 3 chunks +4 lines, -1 line 0 comments Download
M webkit/appcache/appcache_storage_impl.cc View 1 2 3 4 5 2 chunks +7 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_storage_impl_unittest.cc View 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_thread.h View 1 2 3 4 5 3 chunks +1 line, -8 lines 0 comments Download
M webkit/appcache/appcache_thread.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/simple_appcache_system.cc View 3 4 5 2 chunks +4 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 4 chunks +18 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 5 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.h View 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.cc View 3 4 5 2 chunks +4 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.h View 3 4 5 4 chunks +4 lines, -107 lines 0 comments Download
A + webkit/tools/test_shell/test_shell_webkit_init.cc View 5 1 chunk +73 lines, -218 lines 0 comments Download
Project "None" does not have a commit queue.

Messages

Total messages: 9 (0 generated)
rvargas (out until 9-8)
5 years, 3 months ago (2010-05-27 00:12:23 UTC) #1
rvargas (out until 9-8)
5 years, 3 months ago (2010-05-27 00:35:02 UTC) #2
michaeln
looks reasonable to me... but the unittests (webkit/test_shell_tests) and test_shell (test_shell/simple_appcache_system.cc) need some poking
5 years, 3 months ago (2010-05-27 01:59:57 UTC) #3
rvargas (out until 9-8)
Please take another look.
5 years, 3 months ago (2010-05-29 01:53:19 UTC) #4
michaeln
The use of the global g_cache_thread is kind of sketchy. The awkwardness of having test_shell ...
5 years, 2 months ago (2010-05-31 17:59:13 UTC) #5
rvargas (out until 9-8)
On 2010/05/31 17:59:13, michaeln wrote: > The use of the global g_cache_thread is kind of ...
5 years, 2 months ago (2010-06-01 19:12:38 UTC) #6
rvargas (out until 9-8)
(I forgot to send this part) http://codereview.chromium.org/2249005/diff/56001/57020 File webkit/tools/test_shell/test_shell_webkit_init.cc (right): http://codereview.chromium.org/2249005/diff/56001/57020#newcode5 webkit/tools/test_shell/test_shell_webkit_init.cc:5: #include "webkit/tools/test_shell/test_shell_webkit_init.h" On ...
5 years, 2 months ago (2010-06-01 20:08:40 UTC) #7
rvargas (out until 9-8)
Please take another look.
5 years, 2 months ago (2010-06-06 02:42:45 UTC) #8
michaeln
5 years, 2 months ago (2010-06-07 22:22:05 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld a4c4f45