Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2248973005: mojo: Struct traits for gpu buffer types. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Struct traits for gpu buffer types. BUG=637923 TBR=sky@ for trivial services/ui/gpu update. Committed: https://crrev.com/0f4b93cef1da595d51b79c84e3ce1601e4efab4c Cr-Commit-Position: refs/heads/master@{#412581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -32 lines) Patch
M services/ui/gpu/gpu_service_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/gpu/gpu_service_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/public/interfaces/gpu_memory_buffer.mojom View 1 chunk +0 lines, -26 lines 0 comments Download
M services/ui/public/interfaces/gpu_service.mojom View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/gfx/mojo/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ui/gfx/mojo/buffer_types.mojom View 1 chunk +36 lines, -0 lines 0 comments Download
A ui/gfx/mojo/buffer_types.typemap View 1 chunk +14 lines, -0 lines 0 comments Download
A ui/gfx/mojo/buffer_types_enum_traits.h View 1 chunk +144 lines, -0 lines 0 comments Download
M ui/gfx/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
sadrul
4 years, 4 months ago (2016-08-17 02:17:35 UTC) #4
Tom Sepez
lgtm
4 years, 4 months ago (2016-08-17 17:09:32 UTC) #8
sadrul
+sky@ for services/ui (will TBR since trivial change)
4 years, 4 months ago (2016-08-17 17:49:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248973005/1
4 years, 4 months ago (2016-08-17 17:51:13 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 17:56:05 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0f4b93cef1da595d51b79c84e3ce1601e4efab4c Cr-Commit-Position: refs/heads/master@{#412581}
4 years, 4 months ago (2016-08-17 18:01:31 UTC) #17
sky
4 years, 4 months ago (2016-08-17 19:38:42 UTC) #18
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698