Settings People Revamp: Fix Submit passphrase button placement.

Settings People Revamp: Fix Submit passphrase button placement.

BUG=623864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/00f9c87065284d73bea9b86861f03fc4ca2aad59
Cr-Commit-Position: refs/heads/master@{#412853}

[tommycli, 2016-08-16 20:59:13]

Description was changed from

==========
Settings People Revamp: Fix Submit passphrase button placement.

BUG=623864
==========

to

==========
Settings People Revamp: Fix Submit passphrase button placement.

BUG=623864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-16 21:00:00]

Description was changed from

==========
Settings People Revamp: Fix Submit passphrase button placement.

BUG=623864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People Revamp: Fix Submit passphrase button placement.

BUG=623864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-16 21:00:00]

tommycli@chromium.org changed reviewers:
+ dschuyler@chromium.org

[tommycli, 2016-08-16 21:00:23]

dschuyler: PTAL

Before and after pics: http://imgur.com/a/ndGPF (bad one is before)

[tommycli, 2016-08-17 21:59:06]

On 2016/08/16 21:00:23, tommycli wrote:
> dschuyler: PTAL
> 
> Before and after pics: http://imgur.com/a/ndGPF (bad one is before)

dschuyler: ping

[dschuyler, 2016-08-17 23:46:34]

https://codereview.chromium.org/2248973004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/sync_page.html (right):

https://codereview.chromium.org/2248973004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/sync_page.html:28:
-webkit-margin-end: 16px;
I think that in rtl the margin will go
on the other side, but the button will 
still be on the right. Maybe this could
be margin-right, or the button and
input could be swapped, or the button
could be put under again (with more space
for the error)?

(Or maybe I'm wrong - please let me know).

[tommycli, 2016-08-18 00:06:50]

https://codereview.chromium.org/2248973004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/sync_page.html (right):

https://codereview.chromium.org/2248973004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/sync_page.html:28:
-webkit-margin-end: 16px;
On 2016/08/17 23:46:34, dschuyler wrote:
> I think that in rtl the margin will go
> on the other side, but the button will 
> still be on the right. Maybe this could
> be margin-right, or the button and
> input could be swapped, or the button
> could be put under again (with more space
> for the error)?
> 
> (Or maybe I'm wrong - please let me know).

The button and input are auto-swapped in RTL.

See: http://imgur.com/a/7llIl

[dschuyler, 2016-08-18 01:26:22]

Thanks!
LGTM

[tommycli, 2016-08-18 15:30:54]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-18 15:31:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 16:39:09]

Description was changed from

==========
Settings People Revamp: Fix Submit passphrase button placement.

BUG=623864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People Revamp: Fix Submit passphrase button placement.

BUG=623864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-18 16:39:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-18 16:40:41]

Description was changed from

==========
Settings People Revamp: Fix Submit passphrase button placement.

BUG=623864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings People Revamp: Fix Submit passphrase button placement.

BUG=623864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/00f9c87065284d73bea9b86861f03fc4ca2aad59
Cr-Commit-Position: refs/heads/master@{#412853}
==========

[commit-bot: I haz the power, 2016-08-18 16:40:45]

Patchset 1 (id:??) landed as
https://crrev.com/00f9c87065284d73bea9b86861f03fc4ca2aad59
Cr-Commit-Position: refs/heads/master@{#412853}