Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2248963005: DevTools: Support loading of legacy CPU profile format. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
paulirish, dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Support loading of legacy CPU profile format. This is a followup after r412613 to support legacy format loading. Committed: https://crrev.com/f6c0a82b20c1a96e24d1e16d2e739bc158f00651 Cr-Commit-Position: refs/heads/master@{#412767}

Patch Set 1 #

Total comments: 3

Messages

Total messages: 11 (3 generated)
alph
4 years, 4 months ago (2016-08-17 23:26:27 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2248963005/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js (right): https://codereview.chromium.org/2248963005/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js#newcode68 third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js:68: profile.head = null; Maybe delete profile.head?
4 years, 4 months ago (2016-08-18 01:55:16 UTC) #3
alph
https://codereview.chromium.org/2248963005/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js (right): https://codereview.chromium.org/2248963005/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js#newcode68 third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js:68: profile.head = null; On 2016/08/18 01:55:15, dgozman wrote: > ...
4 years, 4 months ago (2016-08-18 05:22:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248963005/1
4 years, 4 months ago (2016-08-18 05:23:13 UTC) #6
dgozman
https://codereview.chromium.org/2248963005/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js (right): https://codereview.chromium.org/2248963005/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js#newcode68 third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js:68: profile.head = null; On 2016/08/18 05:22:48, alph wrote: > ...
4 years, 4 months ago (2016-08-18 05:30:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 08:15:24 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f6c0a82b20c1a96e24d1e16d2e739bc158f00651 Cr-Commit-Position: refs/heads/master@{#412767}
4 years, 4 months ago (2016-08-18 08:18:50 UTC) #10
paulirish
4 years, 4 months ago (2016-08-18 08:23:22 UTC) #11
Message was sent while issue was closed. 
lgtm. thanks for the hookup on this!

Powered by Google App Engine
This is Rietveld 408576698