Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2248963002: remove a download from auto resumption list when cancel/fail (Closed)

Created:
4 years, 4 months ago by qinmin
Modified:
4 years, 4 months ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove a download from auto resumption list when cancel/fail When a download is cancelled/failed/removed, it should be removed from auto resume list. Otherwise, resumption will be retried over and over as it is never removed from auto resumption. BUG=636724 Committed: https://crrev.com/71f2eaba1425d8a8cf351ca5a419e1ee390995c8 Cr-Commit-Position: refs/heads/master@{#412750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 4 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 4 months ago (2016-08-15 23:10:14 UTC) #2
Ted C
lgtm
4 years, 4 months ago (2016-08-18 03:40:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248963002/1
4 years, 4 months ago (2016-08-18 04:35:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 05:40:12 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 05:42:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71f2eaba1425d8a8cf351ca5a419e1ee390995c8
Cr-Commit-Position: refs/heads/master@{#412750}

Powered by Google App Engine
This is Rietveld 408576698