Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2248943003: Disable zlib compression in Blimp until crbug.com/637376 fixed. (Closed)

Created:
4 years, 4 months ago by Kevin M
Modified:
4 years, 4 months ago
Reviewers:
CJ, Khushal
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, prabhur1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable zlib compression in Blimp until crbug.com/637376 fixed. There is a compiler/code optimization bug in zlib's SIMD implementation, which will take time to investigate and fix. This CL restores functionality in Blimp by disabling compression. This CL can be rolled back once the root cause of crbug.com/637736 is addressed. R=lethalantidote@chromium.org CC=wez@chromium.org BUG=637376 Committed: https://crrev.com/f00397506bfb597772b87b1446828771c466a725 Cr-Commit-Position: refs/heads/master@{#412346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M blimp/net/stream_socket_connection.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Kevin M
4 years, 4 months ago (2016-08-16 20:57:59 UTC) #1
CJ
lgtm
4 years, 4 months ago (2016-08-16 21:01:11 UTC) #3
Khushal
+prabhur FYI since this will cause a data regression.
4 years, 4 months ago (2016-08-16 21:01:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248943003/1
4 years, 4 months ago (2016-08-16 21:02:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 21:45:18 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 21:47:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f00397506bfb597772b87b1446828771c466a725
Cr-Commit-Position: refs/heads/master@{#412346}

Powered by Google App Engine
This is Rietveld 408576698