Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2248943002: Class fields cannot be declared to be of type void (Closed)

Created:
4 years, 4 months ago by hausner
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Class fields cannot be declared to be of type void Add a test case and detect void fields. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3f9379199131ca780ff0e1602448aa6b85436b0e

Patch Set 1 #

Patch Set 2 : wip #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M runtime/vm/parser.cc View 1 1 chunk +2 lines, -0 lines 1 comment Download
M tests/language/syntax_test.dart View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 4 months ago (2016-08-15 23:21:50 UTC) #3
rmacnak
lgtm https://chromiumcodereview.appspot.com/2248943002/diff/20001/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/2248943002/diff/20001/runtime/vm/parser.cc#newcode4499 runtime/vm/parser.cc:4499: ReportError(member.name_pos, "field may not be 'void'"); Would be ...
4 years, 4 months ago (2016-08-15 23:55:58 UTC) #4
hausner
4 years, 4 months ago (2016-08-16 00:15:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3f9379199131ca780ff0e1602448aa6b85436b0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698