Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 224893002: device/bluetooth: Rename device::bluetooth_utils::UUID to device::BluetoothUUID (Closed)

Created:
6 years, 8 months ago by armansito
Modified:
6 years, 8 months ago
Reviewers:
keybuk, miket_OOO, rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

device/bluetooth: Rename device::bluetooth_utils::UUID to device::BluetoothUUID Moved bluetooth_utils::UUID into its own file called bluetooth_uuid.h/cc as class BluetoothUUID. This effectively removes the usage of bluetooth_utils::CanonicalUuid. This is a post-revert reupload of https://codereview.chromium.org/220323004/. The CQ didn't run any Mac bots that build and run device_unittests. BUG=358874 TEST=device_unittests, browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -547 lines) Patch
M chrome/browser/extensions/api/bluetooth/bluetooth_api.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_api_utils.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router.h View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_event_router_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth/on_connection/runtest.js View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 9 chunks +21 lines, -17 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 4 chunks +3 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_device.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 5 chunks +14 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_mac.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_device_win_unittest.cc View 6 chunks +10 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_characteristic.h View 3 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_characteristic.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_descriptor.h View 9 chunks +10 lines, -10 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_descriptor.cc View 2 chunks +13 lines, -15 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_service.h View 3 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_profile.h View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_profile.cc View 2 chunks +1 line, -3 lines 0 comments Download
M device/bluetooth/bluetooth_profile_chromeos.h View 4 chunks +4 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_profile_chromeos.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_profile_chromeos_unittest.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_profile_mac.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_profile_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_profile_win.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_profile_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_service_record.h View 3 chunks +3 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_service_record_mac.mm View 1 chunk +3 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_service_record_mac_unittest.mm View 3 chunks +5 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_service_record_win.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M device/bluetooth/bluetooth_service_record_win_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
D device/bluetooth/bluetooth_utils.h View 1 chunk +0 lines, -106 lines 0 comments Download
D device/bluetooth/bluetooth_utils.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D device/bluetooth/bluetooth_utils_unittest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
A + device/bluetooth/bluetooth_uuid.h View 4 chunks +16 lines, -28 lines 0 comments Download
A + device/bluetooth/bluetooth_uuid.cc View 4 chunks +16 lines, -25 lines 0 comments Download
A device/bluetooth/bluetooth_uuid_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 2 chunks +2 lines, -1 line 0 comments Download
M device/device_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
armansito
Post-revert reupload of https://codereview.chromium.org/220323004/. PTAL.
6 years, 8 months ago (2014-04-03 23:51:01 UTC) #1
miket_OOO
On 2014/04/03 23:51:01, armansito wrote: > Post-revert reupload of https://codereview.chromium.org/220323004/. PTAL. Rubber-stamp LGTM reland
6 years, 8 months ago (2014-04-03 23:56:25 UTC) #2
keybuk
lgtm
6 years, 8 months ago (2014-04-04 00:01:44 UTC) #3
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 8 months ago (2014-04-04 02:31:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/224893002/1
6 years, 8 months ago (2014-04-04 02:31:53 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 04:10:46 UTC) #6
Message was sent while issue was closed.
Change committed as 261663

Powered by Google App Engine
This is Rietveld 408576698