Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issue 2248923002: Revert of SkPDF: unify drawText and drawPosText (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkPDF: unify drawText and drawPosText (patchset #2 id:40001 of https://codereview.chromium.org/2241683005/ ) Reason for revert: I believe this is breaking the Google3 roll Original issue's description: > SkPDF: unify drawText and drawPosText > > Motivation: a later CL will add drawTextBlob() (after > https://crrev.com/2084533004 lands). This CL is designed > with that change in mind. Also fewer redundant lines of > code. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2241683005 > > Committed: https://skia.googlesource.com/skia/+/6059dc32fe36358175cb81541c91e74a2a7e771a TBR=bungeman@google.com,halcanary@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/5ba165ee9cd8dc5ea0d10f6a035a3d0cf7c132cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -180 lines) Patch
M src/pdf/SkPDFDevice.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 8 chunks +250 lines, -152 lines 0 comments Download
M src/pdf/SkPDFFont.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 2 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
robertphillips
Created Revert of SkPDF: unify drawText and drawPosText
4 years, 4 months ago (2016-08-15 22:36:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248923002/1
4 years, 4 months ago (2016-08-15 22:36:53 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 22:37:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5ba165ee9cd8dc5ea0d10f6a035a3d0cf7c132cd

Powered by Google App Engine
This is Rietveld 408576698