In deps_updater.py: After updating, set commit and close on CQ failure.

third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
index 0d600f2cb4ac51f3c4cf9f99e7e8a7c80e56fbe8..1c62b4c3215616e01dfb7ddbf23d9511357544ac 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
@@ -82,9 +82,13 @@ class DepsUpdater(object):
             self.print_('## Waiting for Try Job Results')
             if self.has_failing_results():
                 self.write_test_expectations()
-            else:
-                self.print_('No Failures, committing patch.')
-            self.run(['git', 'cl', 'land', '-f', '--auth-refresh-token-json', self.auth_refresh_token_json])
+            self.run(['git', 'cl', 'set-commit', '--rietveld',
+                      '--auth-refresh-token-json', self.auth_refresh_token_json])
+            if self.has_failing_results():
+                self.print_('## CL has failing results when trying to land; aborting.')
+                self.run(['git', 'cl', 'set-close', '--auth-refresh-token-json', self.auth_refresh_token_json])
+                return 1

[qyearsley, 2016/08/16 22:35:59]

Note, this CL should make it so that after trying to commit, the script then
waits for all of the try jobs (in the CQ) to finish; if there are any failing
try jobs, then the main method should return 1 after closing the CL.

So, if there are any failing CQ try jobs then the overall script should have a
non-zero exit code, and I'm assuming that this should turn the step and the
build red.

I haven't tried this out yet though.

+            self.print_('## Auto-update complete.')
         return 0
 
     def parse_args(self, argv):
@@ -344,7 +348,7 @@ class DepsUpdater(object):
         self.run([self.host.executable, script_path])
         message = '\'Modifies TestExpectations and/or downloads new baselines for tests\''
         self.check_run(['git', 'commit', '-a', '-m', message])
-        self.check_run(['git', 'cl', 'upload', '-m', message,
+        self.check_run(['git', 'cl', 'upload', '-m', message, '--rietveld'
                         '--auth-refresh-token-json', self.auth_refresh_token_json])
 
     def has_failing_results(self):
@@ -364,7 +368,7 @@ class DepsUpdater(object):
 
 TBR=qyearsley@chromium.org"""
 
-        command = ['git', 'cl', 'upload', '-f', '-m', message]
+        command = ['git', 'cl', 'upload', '-f', '-m', message, '--rietveld']
         command += ['--cc=' + email for email in email_list]
         if self.auth_refresh_token_json:
             command += ['--auth-refresh-token-json', self.auth_refresh_token_json]