Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2248903002: [fuchsia] Make the dependency on runtime library explicit (Closed)

Created:
4 years, 4 months ago by Petr Hosek
Modified:
4 years, 4 months ago
Reviewers:
zra, jamesr
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[fuchsia] Make the dependency on runtime library explicit The runtime library is an internal implementation detail and we should not be automatically linked into all targets. Any target that for some reason requires runtime should make this dependency explicit. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/6c2e769e348952261d00f4f87d03af9b4888f939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/vm/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Petr Hosek
4 years, 4 months ago (2016-08-15 22:10:57 UTC) #3
zra
lgtm
4 years, 4 months ago (2016-08-15 22:14:45 UTC) #4
jamesr
4 years, 4 months ago (2016-08-15 22:29:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c2e769e348952261d00f4f87d03af9b4888f939 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698