Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: src/value-serializer.h

Issue 2248893003: Blink-compatible deserialization of old object format. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@vs4
Patch Set: correct to size_t Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/value-serializer.cc » ('j') | src/value-serializer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/value-serializer.h
diff --git a/src/value-serializer.h b/src/value-serializer.h
index 9911b3084360920f94be883a3d24bbf671a3cd56..20c88e144b8d85ef56720341c53532ff6344587a 100644
--- a/src/value-serializer.h
+++ b/src/value-serializer.h
@@ -112,9 +112,20 @@ class ValueDeserializer {
*/
MaybeHandle<Object> ReadObject() WARN_UNUSED_RESULT;
+ /*
+ * Reads an object, consuming the entire buffer.
+ *
+ * This is required for the legacy "version 0" format, which did not allow
+ * reference deduplication, and instead relied on a "stack" model for
+ * deserializing, with the contents of objects and arrays provided first.
+ */
+ MaybeHandle<Object> ReadObjectUsingEntireBufferForLegacyFormat()
+ WARN_UNUSED_RESULT;
+
private:
// Reading the wire format.
Maybe<SerializationTag> PeekTag() const WARN_UNUSED_RESULT;
+ void ConsumeTag(SerializationTag peeked_tag);
Maybe<SerializationTag> ReadTag() WARN_UNUSED_RESULT;
template <typename T>
Maybe<T> ReadVarint() WARN_UNUSED_RESULT;
« no previous file with comments | « no previous file | src/value-serializer.cc » ('j') | src/value-serializer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698