appengine/gaemiddleware/context.go - Issue 2248893002: Settings page for analytics ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/gaemiddleware/context.go

Issue 2248893002: Settings page for analytics ID (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: y Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/gaemiddleware/context.go

diff --git a/appengine/gaemiddleware/context.go b/appengine/gaemiddleware/context.go

index f67f6d674d065ad342e52429cde4908dd78e67eb..7f14ab67b56fc25e97c78b9a2c21450949d0c03e 100644

--- a/appengine/gaemiddleware/context.go

+++ b/appengine/gaemiddleware/context.go

@@ -79,9 +79,9 @@ func WithProd(c context.Context, req *http.Request) context.Context {

c = settings.Use(c, globalSettings)

// Fetch and apply configuration stored in the datastore.

- settings := fetchCachedSettings(c)

- c = logging.SetLevel(c, settings.LoggingLevel)

- if !settings.DisableDSCache {

+ cachedSettings := fetchCachedSettings(c)

+ c = logging.SetLevel(c, cachedSettings.LoggingLevel)

+ if !cachedSettings.DisableDSCache {

c = dscache.AlwaysFilterRDS(c, nil)

}