chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('k') | chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

index a7006b880fa4f6ae6e002b3ffe78707e1d37cd40..e2bbe87609019972df65b6e42b9441be17732d70 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

@@ -75,7 +75,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTest, PrintCommands) {

content::TestNavigationObserver reload_observer(

browser()->tab_strip_model()->GetActiveWebContents());

- chrome::Reload(browser(), CURRENT_TAB);

+ chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB);

reload_observer.Wait();

ASSERT_TRUE(chrome::IsCommandEnabled(browser(), IDC_PRINT));

@@ -129,7 +129,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTest, DISABLED_NoCrashOnCloseWithOtherTabs) {

Print();

ui_test_utils::NavigateToURLWithDisposition(

- browser(), GURL("about:blank"), NEW_FOREGROUND_TAB,

+ browser(), GURL("about:blank"), WindowOpenDisposition::NEW_FOREGROUND_TAB,

ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);

browser()->tab_strip_model()->ActivateTabAt(0, true);