chrome/browser/ui/views/outdated_upgrade_bubble_view.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/outdated_upgrade_bubble_view.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/outdated_upgrade_bubble_view.cc

diff --git a/chrome/browser/ui/views/outdated_upgrade_bubble_view.cc b/chrome/browser/ui/views/outdated_upgrade_bubble_view.cc

index aac7ae191d123cc74084a18c31f5310a69880ae0..f525c1dcc38f6ed127b54c204bb40e9e03ad114c 100644

--- a/chrome/browser/ui/views/outdated_upgrade_bubble_view.cc

+++ b/chrome/browser/ui/views/outdated_upgrade_bubble_view.cc

@@ -125,9 +125,10 @@ bool OutdatedUpgradeBubbleView::Accept() {

kNumIgnoredBuckets);

content::RecordAction(

base::UserMetricsAction("OutdatedUpgradeBubble.Reinstall"));

- navigator_->OpenURL(content::OpenURLParams(

- GURL(kDownloadChromeUrl), content::Referrer(), NEW_FOREGROUND_TAB,

- ui::PAGE_TRANSITION_LINK, false));

+ navigator_->OpenURL(

+ content::OpenURLParams(GURL(kDownloadChromeUrl), content::Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false));

#if defined(OS_WIN)

} else {

DCHECK(UpgradeDetector::GetInstance()->is_outdated_install_no_au());