Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 blink::WebStringToGURL(request.httpHeaderField( 307 blink::WebStringToGURL(request.httpHeaderField(
308 WebString::fromUTF8("Referer"))), 308 WebString::fromUTF8("Referer"))),
309 request.referrerPolicy()); 309 request.referrerPolicy());
310 } 310 }
311 311
312 // static 312 // static
313 WindowOpenDisposition RenderViewImpl::NavigationPolicyToDisposition( 313 WindowOpenDisposition RenderViewImpl::NavigationPolicyToDisposition(
314 WebNavigationPolicy policy) { 314 WebNavigationPolicy policy) {
315 switch (policy) { 315 switch (policy) {
316 case blink::WebNavigationPolicyIgnore: 316 case blink::WebNavigationPolicyIgnore:
317 return IGNORE_ACTION; 317 return WindowOpenDisposition::IGNORE_ACTION;
318 case blink::WebNavigationPolicyDownload: 318 case blink::WebNavigationPolicyDownload:
319 return SAVE_TO_DISK; 319 return WindowOpenDisposition::SAVE_TO_DISK;
320 case blink::WebNavigationPolicyCurrentTab: 320 case blink::WebNavigationPolicyCurrentTab:
321 return CURRENT_TAB; 321 return WindowOpenDisposition::CURRENT_TAB;
322 case blink::WebNavigationPolicyNewBackgroundTab: 322 case blink::WebNavigationPolicyNewBackgroundTab:
323 return NEW_BACKGROUND_TAB; 323 return WindowOpenDisposition::NEW_BACKGROUND_TAB;
324 case blink::WebNavigationPolicyNewForegroundTab: 324 case blink::WebNavigationPolicyNewForegroundTab:
325 return NEW_FOREGROUND_TAB; 325 return WindowOpenDisposition::NEW_FOREGROUND_TAB;
326 case blink::WebNavigationPolicyNewWindow: 326 case blink::WebNavigationPolicyNewWindow:
327 return NEW_WINDOW; 327 return WindowOpenDisposition::NEW_WINDOW;
328 case blink::WebNavigationPolicyNewPopup: 328 case blink::WebNavigationPolicyNewPopup:
329 return NEW_POPUP; 329 return WindowOpenDisposition::NEW_POPUP;
330 default: 330 default:
331 NOTREACHED() << "Unexpected WebNavigationPolicy"; 331 NOTREACHED() << "Unexpected WebNavigationPolicy";
332 return IGNORE_ACTION; 332 return WindowOpenDisposition::IGNORE_ACTION;
333 } 333 }
334 } 334 }
335 335
336 // Returns true if the device scale is high enough that losing subpixel 336 // Returns true if the device scale is high enough that losing subpixel
337 // antialiasing won't have a noticeable effect on text quality. 337 // antialiasing won't have a noticeable effect on text quality.
338 static bool DeviceScaleEnsuresTextQuality(float device_scale_factor) { 338 static bool DeviceScaleEnsuresTextQuality(float device_scale_factor) {
339 #if defined(OS_ANDROID) 339 #if defined(OS_ANDROID)
340 // On Android, we never have subpixel antialiasing. 340 // On Android, we never have subpixel antialiasing.
341 return true; 341 return true;
342 #else 342 #else
(...skipping 1240 matching lines...) Expand 10 before | Expand all | Expand 10 after
1583 view_params.renderer_preferences = renderer_preferences_; 1583 view_params.renderer_preferences = renderer_preferences_;
1584 view_params.web_preferences = webkit_preferences_; 1584 view_params.web_preferences = webkit_preferences_;
1585 view_params.view_id = reply.route_id; 1585 view_params.view_id = reply.route_id;
1586 view_params.main_frame_routing_id = reply.main_frame_route_id; 1586 view_params.main_frame_routing_id = reply.main_frame_route_id;
1587 view_params.main_frame_widget_routing_id = reply.main_frame_widget_route_id; 1587 view_params.main_frame_widget_routing_id = reply.main_frame_widget_route_id;
1588 view_params.session_storage_namespace_id = 1588 view_params.session_storage_namespace_id =
1589 reply.cloned_session_storage_namespace_id; 1589 reply.cloned_session_storage_namespace_id;
1590 view_params.swapped_out = false; 1590 view_params.swapped_out = false;
1591 // WebCore will take care of setting the correct name. 1591 // WebCore will take care of setting the correct name.
1592 view_params.replicated_frame_state = FrameReplicationState(); 1592 view_params.replicated_frame_state = FrameReplicationState();
1593 view_params.hidden = (params.disposition == NEW_BACKGROUND_TAB); 1593 view_params.hidden =
1594 (params.disposition == WindowOpenDisposition::NEW_BACKGROUND_TAB);
1594 view_params.never_visible = never_visible; 1595 view_params.never_visible = never_visible;
1595 view_params.next_page_id = 1; 1596 view_params.next_page_id = 1;
1596 view_params.initial_size = initial_size; 1597 view_params.initial_size = initial_size;
1597 view_params.enable_auto_resize = false; 1598 view_params.enable_auto_resize = false;
1598 view_params.min_size = gfx::Size(); 1599 view_params.min_size = gfx::Size();
1599 view_params.max_size = gfx::Size(); 1600 view_params.max_size = gfx::Size();
1600 view_params.page_zoom_level = page_zoom_level_; 1601 view_params.page_zoom_level = page_zoom_level_;
1601 1602
1602 RenderViewImpl* view = 1603 RenderViewImpl* view =
1603 RenderViewImpl::Create(compositor_deps_, view_params, true); 1604 RenderViewImpl::Create(compositor_deps_, view_params, true);
(...skipping 1476 matching lines...) Expand 10 before | Expand all | Expand 10 after
3080 return render_frame->focused_pepper_plugin(); 3081 return render_frame->focused_pepper_plugin();
3081 } 3082 }
3082 frame = frame->traverseNext(false); 3083 frame = frame->traverseNext(false);
3083 } 3084 }
3084 3085
3085 return nullptr; 3086 return nullptr;
3086 } 3087 }
3087 #endif 3088 #endif
3088 3089
3089 } // namespace content 3090 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698