chrome/browser/extensions/extension_uninstall_dialog.cc - Issue 2248873002: Convert WindowOpenDisposition to an enum class.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_uninstall_dialog.cc

Issue 2248873002: Convert WindowOpenDisposition to an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix weird formatting in recent_tabs_sub_menu_model.cc Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tab_util_browsertest.cc ('k') | chrome/browser/extensions/extension_view_host.cc » ('j') | ui/base/window_open_disposition.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/extension_uninstall_dialog.h"	5 #include "chrome/browser/extensions/extension_uninstall_dialog.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/logging.h"	8 #include "base/logging.h"

9 #include "base/message_loop/message_loop.h"	9 #include "base/message_loop/message_loop.h"

10 #include "base/metrics/histogram_macros.h"	10 #include "base/metrics/histogram_macros.h"

(...skipping 177 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
188 }	188 }

189	189

190 delegate_->OnExtensionUninstallDialogClosed(success, error);	190 delegate_->OnExtensionUninstallDialogClosed(success, error);

191 }	191 }

192	192

193 void ExtensionUninstallDialog::HandleReportAbuse() {	193 void ExtensionUninstallDialog::HandleReportAbuse() {

194 chrome::NavigateParams params(	194 chrome::NavigateParams params(

195 profile_,	195 profile_,

196 extension_urls::GetWebstoreReportAbuseUrl(extension_->id(), kReferrerId),	196 extension_urls::GetWebstoreReportAbuseUrl(extension_->id(), kReferrerId),

197 ui::PAGE_TRANSITION_LINK);	197 ui::PAGE_TRANSITION_LINK);

198 params.disposition = NEW_FOREGROUND_TAB;	198 params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;

199 chrome::Navigate(&params);	199 chrome::Navigate(&params);

200 }	200 }

201	201

202 } // namespace extensions	202 } // namespace extensions

OLD	NEW