Log first meaningful paint for the document.write evaluator

Log first meaningful paint for the document.write evaluator

BUG=637937
Committed: https://crrev.com/f28f971c7a4d49d44fd97aaf1ec709910f164c3f
Cr-Commit-Position: refs/heads/master@{#412373}

[Charlie Harrison, 2016-08-15 20:34:23]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 20:34:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-08-15 20:57:51]

Description was changed from

==========
Log first meaningful paint for the document.write evaluator

BUG=
==========

to

==========
Log first meaningful paint for the document.write evaluator

BUG=637937
==========

[Charlie Harrison, 2016-08-15 20:58:47]

csharrison@chromium.org changed reviewers:
+ ksakamoto@chromium.org

[Charlie Harrison, 2016-08-15 20:58:48]

ksakamoto@, are you supportive of consumers using this value? WDYT about logging
this value in all cases (i.e. not filtering out user gestures)?

[commit-bot: I haz the power, 2016-08-15 21:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 21:30:30]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-08-15 21:31:52]

On 2016/08/15 20:58:48, Charlie Harrison wrote:
> ksakamoto@, are you supportive of consumers using this value? WDYT about
logging
> this value in all cases (i.e. not filtering out user gestures)?

Note: in this PS I forgot to branch by loading behavior. Will amend.

[Kunihiko Sakamoto, 2016-08-16 03:31:24]

I think this is OK, as long as we compare values only among the DocWrite
histograms.

https://codereview.chromium.org/2248863002/diff/1/chrome/browser/page_load_me...
File
chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
(right):

https://codereview.chromium.org/2248863002/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc:216:
// Because the counts of those instances are low (< 2%), just log everything
Note that this (< 2%) is only canary data. We don't have substantial data from
Android yet.

[Charlie Harrison, 2016-08-16 14:25:25]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 14:25:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 15:27:19]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-08-16 16:33:47]

csharrison@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Charlie Harrison, 2016-08-16 16:33:48]

Thanks! I expanded the comment about 2%.

+asvitkine for histograms.xml

[Alexei Svitkine (slow), 2016-08-16 18:14:56]

lgtm

[Charlie Harrison, 2016-08-16 21:10:26]

ksakamoto, waiting on your OK but feel free to CQ if it's all good. Thanks!

[Kunihiko Sakamoto, 2016-08-16 23:26:52]

The CQ bit was checked by ksakamoto@chromium.org

[Kunihiko Sakamoto, 2016-08-16 23:26:53]

lgtm

[commit-bot: I haz the power, 2016-08-16 23:27:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 23:33:36]

Description was changed from

==========
Log first meaningful paint for the document.write evaluator

BUG=637937
==========

to

==========
Log first meaningful paint for the document.write evaluator

BUG=637937
==========

[commit-bot: I haz the power, 2016-08-16 23:33:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-16 23:35:09]

Description was changed from

==========
Log first meaningful paint for the document.write evaluator

BUG=637937
==========

to

==========
Log first meaningful paint for the document.write evaluator

BUG=637937

Committed: https://crrev.com/f28f971c7a4d49d44fd97aaf1ec709910f164c3f
Cr-Commit-Position: refs/heads/master@{#412373}
==========

[commit-bot: I haz the power, 2016-08-16 23:35:10]

Patchset 2 (id:??) landed as
https://crrev.com/f28f971c7a4d49d44fd97aaf1ec709910f164c3f
Cr-Commit-Position: refs/heads/master@{#412373}