Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 2248843002: MD Settings: Sections shouldn't overlap toolbar or drawer (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Sections shouldn't overlap toolbar or drawer Expanding/collapsing sections should draw underneath the cr-toolbar and app-drawer. Setting the right z-index values ensures this happens. BUG=626612 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/037200ffe4f9042614082852fd47fa84e94f905e Cr-Commit-Position: refs/heads/master@{#412350}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/settings/settings_page_css.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
michaelpg
4 years, 4 months ago (2016-08-16 20:49:38 UTC) #2
Dan Beam
lgtm but please mention what you're fixing in the CL's title rather than what you're ...
4 years, 4 months ago (2016-08-16 20:57:38 UTC) #3
michaelpg
On 2016/08/16 20:57:38, Dan Beam wrote: > lgtm but please mention what you're fixing in ...
4 years, 4 months ago (2016-08-16 21:04:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248843002/1
4 years, 4 months ago (2016-08-16 21:04:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 21:54:56 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 21:59:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/037200ffe4f9042614082852fd47fa84e94f905e
Cr-Commit-Position: refs/heads/master@{#412350}

Powered by Google App Engine
This is Rietveld 408576698