Apply upstream qcmstypes.h patch to avoid conflicts with MSVC's stdint.h

Apply upstream qcmstypes.h patch to avoid conflicts with MSVC's stdint.h

This avoids errors from Clang about a conflicting typedef for
uintptr_t, which should really be unsigned int instead of unsigned
long.  We already had a local patch to suppress MSVC's warning here.
Rather than trying to get the right definition, just include stdint.h,
which has been available since VS2010.

R=thakis@chromium.org
TBR=brettw@chromium.org
BUG=82385
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276887

[Nico, 2014-04-04 01:05:46]

We try to be good open-source citizens and also send patches upstream (or at
least report the issue there) – can you do that and mention that in the README?

With that, lgtm.

(I vaguely remembered there being an issue with stdint, but apparently that was
with 2010 only: http://crbug.com/308740)

[Nico, 2014-04-04 22:49:21]

Oh, and let me point out this line from third_party/OWNERS as it's unusual:

# For changes to existing code simply TBR= one of people below.
…
brettw@chromium.org
…

[Reid Kleckner (google), 2014-04-04 23:41:26]

Sure.  I had held off because I'm not sure if Mozilla will want this
change.  But, I suppose I can file a bug with a patch on it.  This header
has ifdefs for all sorts of OSs: Sun, OS2, etc, so I'm not sure they'll
accept a patch that only works with MSVC 2010 or later.


On Fri, Apr 4, 2014 at 3:49 PM, <thakis@chromium.org> wrote:

> Oh, and let me point out this line from third_party/OWNERS as it's unusual:
>
> # For changes to existing code simply TBR= one of people below.
> ...
> brettw@chromium.org
> ...
>
> https://codereview.chromium.org/224883004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-04-04 23:43:32]

They'd probably take a patch to include stdint.h if msvs >= 2013 (2010 has
that intsafe issue) though (?)


On Fri, Apr 4, 2014 at 4:41 PM, Reid Kleckner <rnk@google.com> wrote:

> Sure.  I had held off because I'm not sure if Mozilla will want this
> change.  But, I suppose I can file a bug with a patch on it.  This header
> has ifdefs for all sorts of OSs: Sun, OS2, etc, so I'm not sure they'll
> accept a patch that only works with MSVC 2010 or later.
>
>
> On Fri, Apr 4, 2014 at 3:49 PM, <thakis@chromium.org> wrote:
>
>> Oh, and let me point out this line from third_party/OWNERS as it's
>> unusual:
>>
>> # For changes to existing code simply TBR= one of people below.
>> ...
>> brettw@chromium.org
>> ...
>>
>> https://codereview.chromium.org/224883004/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-06-11 17:21:25]

Apparently they applied a similar patch earlier this year:
http://hg.mozilla.org/mozilla-central/rev/b5be94737a83

    1.39 <http://hg.mozilla.org/mozilla-central/rev/b5be94737a83#l1.39>
-#elif defined (_MSC_VER)    1.40
<http://hg.mozilla.org/mozilla-central/rev/b5be94737a83#l1.40> +#elif
defined (_MSC_VER) && _MSC_VER < 1600


I'll port that to our copy instead.


On Fri, Apr 4, 2014 at 4:43 PM, Nico Weber <thakis@chromium.org> wrote:

> They'd probably take a patch to include stdint.h if msvs >= 2013 (2010 has
> that intsafe issue) though (?)
>
>
> On Fri, Apr 4, 2014 at 4:41 PM, Reid Kleckner <rnk@google.com> wrote:
>
>> Sure.  I had held off because I'm not sure if Mozilla will want this
>> change.  But, I suppose I can file a bug with a patch on it.  This header
>> has ifdefs for all sorts of OSs: Sun, OS2, etc, so I'm not sure they'll
>> accept a patch that only works with MSVC 2010 or later.
>>
>>
>> On Fri, Apr 4, 2014 at 3:49 PM, <thakis@chromium.org> wrote:
>>
>>> Oh, and let me point out this line from third_party/OWNERS as it's
>>> unusual:
>>>
>>> # For changes to existing code simply TBR= one of people below.
>>> ...
>>> brettw@chromium.org
>>> ...
>>>
>>> https://codereview.chromium.org/224883004/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Reid Kleckner, 2014-06-12 16:39:23]

new patch, ptal

[Nico, 2014-06-12 18:46:29]

lgtm

https://codereview.chromium.org/224883004/diff/20001/third_party/qcms/README....
File third_party/qcms/README.chromium (right):

https://codereview.chromium.org/224883004/diff/20001/third_party/qcms/README....
third_party/qcms/README.chromium:38: -
https://bugzilla.mozilla.org/show_bug.cgi?id=957002
Maybe link to https://hg.mozilla.org/mozilla-central/rev/b5be94737a83 , the diff
attached to that bug looks fairly different from this change (well, the mscver
line is different at least)

[Reid Kleckner, 2014-06-12 18:58:50]

The CQ bit was checked by rnk@chromium.org

[commit-bot: I haz the power, 2014-06-12 19:00:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rnk@chromium.org/224883004/40001

[commit-bot: I haz the power, 2014-06-13 01:19:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-06-13 01:22:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 01:22:26]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Reid Kleckner, 2014-06-13 01:46:22]

Gonna TBR Brett.

[Reid Kleckner, 2014-06-13 01:46:27]

The CQ bit was checked by rnk@chromium.org

[commit-bot: I haz the power, 2014-06-13 01:48:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rnk@chromium.org/224883004/40001

[Nico, 2014-06-13 01:49:34]

$ cat third_party/OWNERS 
# Owner approval for 3rd party is only required for
# adding new libraries. Be sure to follow the instructions for adding
# new third party libraries.
# http://www.chromium.org/developers/adding-3rd-party-libraries
#
# For changes to existing code simply TBR= one of people below.


:-)

[commit-bot: I haz the power, 2014-06-13 02:19:40]

Change committed as 276887