Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2248823003: Use the correct scale factor when rendering RemoteFrames with UseZoomForDSF. (Closed)

Created:
4 years, 4 months ago by lfg
Modified:
4 years, 4 months ago
Reviewers:
oshima, dcheng, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, mlamouri+watch-blink_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the correct scale factor when rendering RemoteFrames with UseZoomForDSF. The view bounds reported by RenderWidgetHostViewChildFrame must return the frame size without the device scale factor applied. BUG=621020 Committed: https://crrev.com/1f9011c2bae856ae3c0c30f10f04e5c027319189 Cr-Commit-Position: refs/heads/master@{#412639}

Patch Set 1 #

Patch Set 2 : use enclosing rect #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M content/renderer/render_frame_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 3 chunks +9 lines, -4 lines 2 comments Download
M content/renderer/render_widget.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 chunk +1 line, -2 lines 1 comment Download
M third_party/WebKit/public/web/WebRemoteFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (14 generated)
lfg
+oshima, please take a look.
4 years, 4 months ago (2016-08-16 19:01:51 UTC) #9
oshima
lgtm
4 years, 4 months ago (2016-08-16 23:02:33 UTC) #12
oshima
oops, sorry I'm still looking.
4 years, 4 months ago (2016-08-16 23:07:24 UTC) #13
oshima
lgtm https://codereview.chromium.org/2248823003/diff/20001/content/renderer/render_frame_proxy.cc File content/renderer/render_frame_proxy.cc (right): https://codereview.chromium.org/2248823003/diff/20001/content/renderer/render_frame_proxy.cc#newcode473 content/renderer/render_frame_proxy.cc:473: rect, 1.f / render_widget_->GetOriginalDeviceScaleFactor()); We probably should update ...
4 years, 4 months ago (2016-08-17 00:17:04 UTC) #14
lfg
https://codereview.chromium.org/2248823003/diff/20001/content/renderer/render_frame_proxy.cc File content/renderer/render_frame_proxy.cc (right): https://codereview.chromium.org/2248823003/diff/20001/content/renderer/render_frame_proxy.cc#newcode473 content/renderer/render_frame_proxy.cc:473: rect, 1.f / render_widget_->GetOriginalDeviceScaleFactor()); On 2016/08/17 00:17:04, oshima wrote: ...
4 years, 4 months ago (2016-08-17 15:37:51 UTC) #15
lfg
dcheng@chromium.org: Please review changes in third_party/WebKit/ piman@chromium.org: Please review changes in content/
4 years, 4 months ago (2016-08-17 15:42:16 UTC) #17
piman
lgtm
4 years, 4 months ago (2016-08-17 16:45:04 UTC) #18
dcheng
https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp File third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp (right): https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp#newcode432 third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp:432: void WebRemoteFrameImpl::initializeFromFrame(WebLocalFrame* source) const Do we still need to ...
4 years, 4 months ago (2016-08-17 17:11:31 UTC) #19
lfg
On 2016/08/17 17:11:31, dcheng wrote: > https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp > File third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp (right): > > https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp#newcode432 > ...
4 years, 4 months ago (2016-08-17 18:18:12 UTC) #20
dcheng
On 2016/08/17 18:18:12, lfg wrote: > On 2016/08/17 17:11:31, dcheng wrote: > > > https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp ...
4 years, 4 months ago (2016-08-17 19:08:00 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248823003/20001
4 years, 4 months ago (2016-08-17 19:32:02 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 21:19:05 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 21:20:35 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f9011c2bae856ae3c0c30f10f04e5c027319189
Cr-Commit-Position: refs/heads/master@{#412639}

Powered by Google App Engine
This is Rietveld 408576698