Use the correct scale factor when rendering RemoteFrames with UseZoomForDSF.

Use the correct scale factor when rendering RemoteFrames with UseZoomForDSF.

The view bounds reported by RenderWidgetHostViewChildFrame must return the frame size without the device scale factor applied.

BUG=621020
Committed: https://crrev.com/1f9011c2bae856ae3c0c30f10f04e5c027319189
Cr-Commit-Position: refs/heads/master@{#412639}

[lfg, 2016-08-16 17:24:57]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 17:25:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 18:42:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 18:42:10]

Dry run: This issue passed the CQ dry run.

[lfg, 2016-08-16 18:58:27]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 18:58:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lfg, 2016-08-16 19:00:56]

Description was changed from

==========
[WIP] Fix DSF Zoom for RemoteFrames.
==========

to

==========
Use the correct scale factor when rendering RemoteFrames with UseZoomForDSF.

The view bounds reported by RenderWidgetHostViewChildFrame must return the frame
size without the device scale factor applied.

BUG=621020
==========

[lfg, 2016-08-16 19:01:51]

lfg@chromium.org changed reviewers:
+ oshima@chromium.org

[lfg, 2016-08-16 19:01:51]

+oshima, please take a look.

[commit-bot: I haz the power, 2016-08-16 22:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 22:50:44]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-08-16 23:02:33]

lgtm

[oshima, 2016-08-16 23:07:24]

oops, sorry I'm still looking.

[oshima, 2016-08-17 00:17:04]

lgtm

https://codereview.chromium.org/2248823003/diff/20001/content/renderer/render...
File content/renderer/render_frame_proxy.cc (right):

https://codereview.chromium.org/2248823003/diff/20001/content/renderer/render...
content/renderer/render_frame_proxy.cc:473: rect, 1.f /
render_widget_->GetOriginalDeviceScaleFactor());
We probably should update the RenderWIdget::convertViewportToWindow to use the
same and switch, but lgtm for now.

[lfg, 2016-08-17 15:37:51]

https://codereview.chromium.org/2248823003/diff/20001/content/renderer/render...
File content/renderer/render_frame_proxy.cc (right):

https://codereview.chromium.org/2248823003/diff/20001/content/renderer/render...
content/renderer/render_frame_proxy.cc:473: rect, 1.f /
render_widget_->GetOriginalDeviceScaleFactor());
On 2016/08/17 00:17:04, oshima wrote:
> We probably should update the RenderWIdget::convertViewportToWindow to use the
> same and switch, but lgtm for now.

I'll put up another CL to update that.

[lfg, 2016-08-17 15:42:15]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org, piman@chromium.org

[lfg, 2016-08-17 15:42:16]

dcheng@chromium.org: Please review changes in 

third_party/WebKit/

piman@chromium.org: Please review changes in 

content/

[piman, 2016-08-17 16:45:04]

lgtm

[dcheng, 2016-08-17 17:11:31]

https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp (right):

https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp:432: void
WebRemoteFrameImpl::initializeFromFrame(WebLocalFrame* source) const
Do we still need to pass |source| here if it's unused?

[lfg, 2016-08-17 18:18:12]

On 2016/08/17 17:11:31, dcheng wrote:
>
https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp (right):
> 
>
https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp:432: void
> WebRemoteFrameImpl::initializeFromFrame(WebLocalFrame* source) const
> Do we still need to pass |source| here if it's unused?

It's not needed, but as I was removing I realized that this whole IPC can be
removed,
as it's only used to send the device scale factor via an IPC to the browser
process.

Do you mind if I do this in a follow-up patch instead of here?

[dcheng, 2016-08-17 19:08:00]

On 2016/08/17 18:18:12, lfg wrote:
> On 2016/08/17 17:11:31, dcheng wrote:
> >
>
https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp (right):
> > 
> >
>
https://codereview.chromium.org/2248823003/diff/20001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp:432: void
> > WebRemoteFrameImpl::initializeFromFrame(WebLocalFrame* source) const
> > Do we still need to pass |source| here if it's unused?
> 
> It's not needed, but as I was removing I realized that this whole IPC can be
> removed,
> as it's only used to send the device scale factor via an IPC to the browser
> process.
> 
> Do you mind if I do this in a follow-up patch instead of here?

OK, LGTM, let's remove this in the followup.

[lfg, 2016-08-17 19:31:00]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2016-08-17 19:32:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:19:04]

Description was changed from

==========
Use the correct scale factor when rendering RemoteFrames with UseZoomForDSF.

The view bounds reported by RenderWidgetHostViewChildFrame must return the frame
size without the device scale factor applied.

BUG=621020
==========

to

==========
Use the correct scale factor when rendering RemoteFrames with UseZoomForDSF.

The view bounds reported by RenderWidgetHostViewChildFrame must return the frame
size without the device scale factor applied.

BUG=621020
==========

[commit-bot: I haz the power, 2016-08-17 21:19:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-17 21:20:33]

Description was changed from

==========
Use the correct scale factor when rendering RemoteFrames with UseZoomForDSF.

The view bounds reported by RenderWidgetHostViewChildFrame must return the frame
size without the device scale factor applied.

BUG=621020
==========

to

==========
Use the correct scale factor when rendering RemoteFrames with UseZoomForDSF.

The view bounds reported by RenderWidgetHostViewChildFrame must return the frame
size without the device scale factor applied.

BUG=621020

Committed: https://crrev.com/1f9011c2bae856ae3c0c30f10f04e5c027319189
Cr-Commit-Position: refs/heads/master@{#412639}
==========

[commit-bot: I haz the power, 2016-08-17 21:20:35]

Patchset 2 (id:??) landed as
https://crrev.com/1f9011c2bae856ae3c0c30f10f04e5c027319189
Cr-Commit-Position: refs/heads/master@{#412639}