Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: src/ast/ast.h

Issue 2248813002: [ast] Clean up a few unnecessary bits in AST (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/ast.h
diff --git a/src/ast/ast.h b/src/ast/ast.h
index c2ff617c482662d6acf80b475f45e121a6e4e0ba..6f0c4e891ae3664f6dfb8967b2b25addafcb7b38 100644
--- a/src/ast/ast.h
+++ b/src/ast/ast.h
@@ -220,8 +220,6 @@ class AstNode: public ZoneObject {
// current zone from the TLS.
void* operator new(size_t size);
- friend class CaseClause; // Generates AST IDs.
-
int position_;
NodeType node_type_;
// Ends with NodeType which is uint8_t sized. Deriving classes in turn begin
@@ -1580,8 +1578,6 @@ class VariableProxy final : public Expression {
return !is_this() && !is_new_target();
}
- bool IsArguments() const { return is_resolved() && var()->is_arguments(); }
-
Handle<String> name() const { return raw_name()->string(); }
const AstRawString* raw_name() const {
return is_resolved() ? var_->raw_name() : raw_name_;
@@ -1651,8 +1647,6 @@ class VariableProxy final : public Expression {
class IsResolvedField : public BitField8<bool, 2, 1> {};
class IsNewTargetField : public BitField8<bool, 3, 1> {};
- // Start with 16-bit (or smaller) field, which should get packed together
- // with Expression's trailing 16-bit field.
uint8_t bit_field_;
// Position is stored in the AstNode superclass, but VariableProxy needs to
// know its end position too (for error messages). It cannot be inferred from
« no previous file with comments | « no previous file | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698