LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-input-field-expected.txt - Issue 22488004: Made text inside <input> elements scrollable using touch gestures

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-input-field-expected.txt

Issue 22488004: Made text inside <input> elements scrollable using touch gestures (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Layout test minor fix Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-input-field.html ('K') | « LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-input-field.html ('k') | Source/core/rendering/RenderBox.h » ('j') | Source/core/rendering/RenderLayer.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1

	2 This tests that an input text field can be properly scrolled with touch gestures
	tdanderson 2013/08/08 20:01:16 Can you do a quick sanity check that everything wo Can you do a quick sanity check that everything works as intended if the text field has the attributes disabled or readonly? (Just try this informally, no need to include it in the layout test.)
	3

	4 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

	5

	6

	7 Flinging input text should scroll the text
	tdanderson 2013/08/08 20:01:16 On lines 7 and 16 make it clear that you're not fl On lines 7 and 16 make it clear that you're not flinging/scrolling the text fully. bokan 2013/08/12 16:19:29 Done Show quoted text On 2013/08/08 20:01:16, tdanderson wrote: > On lines 7 and 16 make it clear that you're not flinging/scrolling the text > fully. Done
	8 PASS box.scrollLeft is 40

	9 PASS container.scrollLeft is 0

	10 Flinging input text past the scrollable width shouldn't scroll containing div

	11 PASS box.scrollLeft is box.scrollWidth - box.clientWidth
	tdanderson 2013/08/08 20:01:16 In the expected results it is better report the ac In the expected results it is better report the actual value of expressions, e.g.: PASS box.scrollLeft is 462 bokan 2013/08/12 16:19:29 Done Show quoted text On 2013/08/08 20:01:16, tdanderson wrote: > In the expected results it is better report the actual value of expressions, > e.g.: > > PASS box.scrollLeft is 462 Done
	12 PASS container.scrollLeft is 0

	13 Flinging fully scrolled input text should fling containing div

	14 PASS box.scrollLeft is box.scrollWidth - box.clientWidth

	15 PASS container.scrollLeft is 60

	16 Gesture scrolling input text a bit should scroll the text
	tdanderson 2013/08/08 20:01:16 I would add a sanity check between the end of the I would add a sanity check between the end of the fling stuff and the start of the non-fling stuff to verify that everything has been reset properly. It isn't clear that you have reset anything just by reading what you have in this file. bokan 2013/08/12 16:19:29 Done. Show quoted text On 2013/08/08 20:01:16, tdanderson wrote: > I would add a sanity check between the end of the fling stuff and the start of > the non-fling stuff to verify that everything has been reset properly. It isn't > clear that you have reset anything just by reading what you have in this file. Done.
	17 PASS box.scrollLeft is 60

	18 PASS container.scrollLeft is 0

	19 Gesture scrolling input text past scroll width should scroll container div

	20 PASS box.scrollLeft is box.scrollWidth - box.clientWidth

	21 PASS container.scrollLeft is 50

	22

OLD	NEW