Tightening up dart2js load timing.

sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * A function element that represents a closure call. The signature is copied
  * from the given element.
  */
@@ skipping 839 matching lines @@
     if (needsDefineClass) {
       copyFinishClasses.add(
           js('newIsolate.$finishClassesProperty = '
              '    oldIsolate.$finishClassesProperty'));
     }
 
     // function(oldIsolate) {
     return js.fun('oldIsolate', [
       js('var isolateProperties = oldIsolate.${namer.isolatePropertiesName}'),
 
-      js(r'isolateProperties.$currentScript ='
-              'typeof document == "object" ?'
-              '(document.currentScript ||'
-                     'document.scripts[document.scripts.length - 1]) :'
-              'null'),
+      js(r'isolateProperties.$currentScript = null'),
 
       js('var isolatePrototype = oldIsolate.prototype'),
       js('var str = "{\\n"'),
       js('str += "var properties = '
                      'arguments.callee.${namer.isolatePropertiesName};\\n"'),
       js('var hasOwnProperty = Object.prototype.hasOwnProperty'),
 
       // for (var staticName in isolateProperties) {
       js.forIn('staticName', 'isolateProperties', [
         js.if_('hasOwnProperty.call(isolateProperties, staticName)', [
@@ skipping 2060 matching lines @@
       mainCall = '${namer.isolateAccess(main)}()';
     }
     if (backend.needToInitializeDispatchProperty) {
       buffer.write(
           jsAst.prettyPrint(generateDispatchPropertyInitialization(),
                             compiler));
       buffer.write(N);
     }
     addComment('BEGIN invoke [main].', buffer);
     buffer.write("""
-if (typeof document !== "undefined" && document.readyState !== "complete") {
-  document.addEventListener("readystatechange", function () {
-    if (document.readyState == "complete") {
-      if (typeof dartMainRunner === "function") {
-        dartMainRunner(function() { ${mainCall}; });
-      } else {
-        ${mainCall};
-      }
+(function (callback) {
+  if (!self.document) {

[ahe, 2013/08/07 16:24:47]

Just a quick note, sorry.

This will break dart2js tests running on d8.  This is what we test on the main
build bots.

Try running:

./tools/test.py -mrelease -cdart2js -rd8

[blois, 2013/08/07 17:39:50]

Ah, thanks!

+    callback(null);
+    return;
+  }
+  if (document.currentScript) {
+    callback(document.currentScript);
+    return;
+  }
+
+  var scripts = document.scripts;
+  function onLoad() {
+    for (var i = 0; i < scripts.length; ++i) {
+      scripts[i].removeEventListener('load', onLoad, false);

[vsm, 2013/08/07 16:10:12]

Can you add a comment here to explain what's going on?  If you hadn't explained
it ahead of time, I think I'd be pretty befuddled here.  Even still, it's tricky
code.

[blois, 2013/08/07 17:39:50]

Done.

     }
-  }, false);
-} else {
+    callback(event.target);
+  }
+  for (var i = 0; i < scripts.length; ++i) {
+    scripts[i].addEventListener('load', onLoad, false);
+  }
+})(function(currentScript) {
+  Isolate.\$isolateProperties.\$currentScript = currentScript;
+
+  if (self.console && self.document && document.readyState == "loading") {
+    // Bug dartbug.com/12281 this warning is to let users know how to match
+    // Dartium execution timing.
+    console.warn("Dart script executed synchronously, use <script src='" +
+        currentScript.src + "' defer></scr" + "ipt> to execute after parsing " +
+        "has completed.");
+  }
   if (typeof dartMainRunner === "function") {
     dartMainRunner(function() { ${mainCall}; });
   } else {
     ${mainCall};
   }
-}
+});
 """);
     addComment('END invoke [main].', buffer);
   }
 
   void emitGetInterceptorMethod(CodeBuffer buffer,
                                 String key,
                                 Iterable<ClassElement> classes) {
     jsAst.Statement buildReturnInterceptor(ClassElement cls) {
       return js.return_(js(namer.isolateAccess(cls))['prototype']);
     }
@@ skipping 1071 matching lines @@
 
 const String HOOKS_API_USAGE = """
 // The code supports the following hooks:
 // dartPrint(message)   - if this function is defined it is called
 //                        instead of the Dart [print] method.
 // dartMainRunner(main) - if this function is defined, the Dart [main]
 //                        method will not be invoked directly.
 //                        Instead, a closure that will invoke [main] is
 //                        passed to [dartMainRunner].
 """;