Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3728)

Unified Diff: chrome/browser/android/metrics/uma_session_stats.cc

Issue 2248793002: Remove OnRecordingDisabled() metrics client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove crash_keys import. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/metrics/uma_session_stats.cc
diff --git a/chrome/browser/android/metrics/uma_session_stats.cc b/chrome/browser/android/metrics/uma_session_stats.cc
index be0a0ded2608b5be048b8482d6c9f6d8b02c495e..e209d4fddba7e04dd1df6da2e6c62fa15ad0fb12 100644
--- a/chrome/browser/android/metrics/uma_session_stats.cc
+++ b/chrome/browser/android/metrics/uma_session_stats.cc
@@ -108,6 +108,8 @@ static void UpdateMetricsServiceState(JNIEnv* env,
DCHECK(metrics);
if (metrics->recording_active() != may_record) {
+ UpdateMetricsPrefsOnPermissionChange(may_record);
+
// This function puts a consent file with the ClientID in the
// data directory. The ID is passed to the renderer for crash
// reporting when things go wrong.
@@ -117,17 +119,6 @@ static void UpdateMetricsServiceState(JNIEnv* env,
may_record));
}
- // Clear the client id pref when opting out. Note: Mirrors code in
- // metrics_reporting_state.cc. TODO(asvitkine): Unify.
- if (!may_record) {
- // Note: Clearing client id will not affect the running state (e.g. field
- // trial randomization), as the pref is only read on startup.
- g_browser_process->local_state()->ClearPref(
- metrics::prefs::kMetricsClientID);
- g_browser_process->local_state()->ClearPref(
- metrics::prefs::kMetricsReportingEnabledTimestamp);
- }
-
g_browser_process->GetMetricsServicesManager()->UpdatePermissions(
may_record, may_upload);
}
« no previous file with comments | « blimp/engine/app/blimp_metrics_service_client.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698