Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2248793002: Remove OnRecordingDisabled() metrics client interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add helper function Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 968ad63d94cee348d825c5651dc01c5987ac4699..f50c205d65b18c665091e7a7a93d554b53867f6e 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -284,13 +284,6 @@ void ChromeMetricsServiceClient::SetMetricsClientId(
crash_keys::SetMetricsClientIdFromGUID(client_id);
}
-void ChromeMetricsServiceClient::OnRecordingDisabled() {
- // If we're shutting down, don't drop the metrics_client_id, so that late
- // crashes won't lose it.
- if (!g_browser_process->IsShuttingDown())
- crash_keys::ClearMetricsClientId();
-}
-
bool ChromeMetricsServiceClient::IsOffTheRecordSessionActive() {
return chrome::IsIncognitoSessionActive();
}

Powered by Google App Engine
This is Rietveld 408576698