|
Remove OnRecordingDisabled() metrics client interface.
This was there so that crash client id could be cleared.
However, this was being called out of MetricsService::Stop(),
so it needed a special provision to not clear it when shutting
down, for example.
This change instead removes all of that plumbing and makes the
id clearing happen in the same place we clear the UMA client id,
when the user actually opts-out (as opposed to just metrics service
stopping). Unifies the prefs manipulation that happens when the
user changes the setting into a helper function.
As a follow up change after this lands, we should also make that
function be called on iOS.
BUG= 635669
TBR=sgurun@chromium.org,nyquist@chromium.org,noyau@chromium.org
Committed: https://crrev.com/12aec333ac6595deb79bc1ea6a59d933e3c11b9a
Cr-Commit-Position: refs/heads/master@{#412568}
Total comments: 4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+30 lines, -67 lines) |
Patch |
|
M |
android_webview/browser/aw_metrics_service_client.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
android_webview/browser/aw_metrics_service_client.cc
|
View
|
|
1 chunk |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
blimp/engine/app/blimp_metrics_service_client.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
blimp/engine/app/blimp_metrics_service_client.cc
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/android/metrics/uma_session_stats.cc
|
View
|
1
2
|
2 chunks |
+2 lines, -11 lines |
0 comments
|
Download
|
|
M |
chrome/browser/metrics/chrome_metrics_service_client.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/metrics/chrome_metrics_service_client.cc
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/metrics/metrics_reporting_state.h
|
View
|
1
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/metrics/metrics_reporting_state.cc
|
View
|
1
|
3 chunks |
+20 lines, -19 lines |
0 comments
|
Download
|
|
M |
chromecast/browser/metrics/cast_metrics_service_client.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
chromecast/browser/metrics/cast_metrics_service_client.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
components/metrics/metrics_service.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
components/metrics/metrics_service_client.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
components/metrics/test_metrics_service_client.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
components/metrics/test_metrics_service_client.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
Total messages: 39 (26 generated)
|