Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2248783003: [DevTools] Refactor CodeGenerator. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Refactor CodeGenerator. Simplified, improved up_to_date, prepared to more config params. BUG=637032 Committed: https://crrev.com/426a8b81c5c4cb53748907d8f0b77cd85e88a0d6 Cr-Commit-Position: refs/heads/master@{#412361}

Patch Set 1 #

Patch Set 2 : up_to_date fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -344 lines) Patch
M third_party/WebKit/Source/core/inspector/inspector_protocol_config.json View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/BackendCallback_h.template View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 9 chunks +207 lines, -272 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_h.template View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport_h.template View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Exported_h.template View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/FrontendChannel_h.template View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Imported_h.template View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/InspectorProtocol_cpp.template View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Object_h.template View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Parser_h.template View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Platform_h.template View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16_h.template View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 9 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Values_h.template View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/sample_config.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/inspector_protocol_config.json View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/inspector_protocol_config_stl.json View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-08-16 16:43:36 UTC) #4
pfeldman
lgtm
4 years, 4 months ago (2016-08-16 19:13:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248783003/1
4 years, 4 months ago (2016-08-16 19:18:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/221277)
4 years, 4 months ago (2016-08-16 20:02:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248783003/20001
4 years, 4 months ago (2016-08-16 20:29:42 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 22:34:27 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 22:37:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/426a8b81c5c4cb53748907d8f0b77cd85e88a0d6
Cr-Commit-Position: refs/heads/master@{#412361}

Powered by Google App Engine
This is Rietveld 408576698