chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc - Issue 2248773002: Use MD-ash's auto hide behavior for arc++ windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

Issue 2248773002: Use MD-ash's auto hide behavior for arc++ windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add AUTO_HIDE_INVISIBLE mode for arc++. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/shelf/shelf_layout_manager_unittest.cc ('K') | « chrome/browser/notifications/fullscreen_notification_blocker.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

index 275661ecc659a66f11ddaf8bf83b7b1d8a426ac8..e03a1b30d3c42c8c2f7a0e3d3e8dd0af40df25a2 100644

--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc

@@ -318,8 +318,10 @@ void ChromeNativeAppWindowViewsAuraAsh::SetFullscreen(int fullscreen_types) {

// OS fullscreen.

ash::wm::WindowState* window_state =

ash::wm::GetWindowState(widget()->GetNativeWindow());

- window_state->set_hide_shelf_when_fullscreen(fullscreen_types !=

- AppWindow::FULLSCREEN_TYPE_OS);

+ window_state->set_shelf_mode_in_fullscreen(

+ fullscreen_types != AppWindow::FULLSCREEN_TYPE_OS

+ ? ash::wm::WindowState::SHELF_HIDDEN

+ : ash::wm::WindowState::SHELF_AUTO_HIDE_VISIBLE);

DCHECK(ash::Shell::HasInstance());

ash::Shell::GetInstance()->UpdateShelfVisibility();

}