Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 224873002: Makes it so mojom files don't need a module (Closed)

Created:
6 years, 8 months ago by sky
Modified:
6 years, 8 months ago
Reviewers:
DaveMoore, viettrungluu
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Makes it so mojom files don't need a module This is for code that doesn't want to use a namespace, such as chrome. BUG=none TEST=none R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261863

Patch Set 1 #

Patch Set 2 : remove viewmanager hack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M mojo/public/bindings/generators/cpp_templates/module-internal.h.tmpl View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/module.cc.tmpl View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/public/bindings/generators/cpp_templates/module.h.tmpl View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_parser.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sky
6 years, 8 months ago (2014-04-03 23:47:39 UTC) #1
DaveMoore
lgtm
6 years, 8 months ago (2014-04-04 15:56:55 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 8 months ago (2014-04-04 16:03:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/224873002/20001
6 years, 8 months ago (2014-04-04 16:03:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 17:34:28 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=91517
6 years, 8 months ago (2014-04-04 17:34:29 UTC) #6
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-04 18:04:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/224873002/20001
6 years, 8 months ago (2014-04-04 18:05:57 UTC) #8
sky
Committed patchset #2 manually as r261863 (presubmit successful).
6 years, 8 months ago (2014-04-04 20:58:11 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 20:58:25 UTC) #10
Message was sent while issue was closed.
Failed to apply the patch.
Sending       
mojo/public/bindings/generators/cpp_templates/module-internal.h.tmpl
Sending        mojo/public/bindings/generators/cpp_templates/module.cc.tmpl
Sending        mojo/public/bindings/generators/cpp_templates/module.h.tmpl
Sending        mojo/public/bindings/pylib/parse/mojo_parser.py
Transmitting file data ....svn: Commit failed (details follow):
svn: File
'/trunk/src/mojo/public/bindings/generators/cpp_templates/module-internal.h.tmpl'
is out of date

Powered by Google App Engine
This is Rietveld 408576698