Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2248693005: [Parser] Track ContainsDot for SMI values. (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Parser] Track ContainsDot for SMI values. Ensures SMI values have SMI type even if they have a dot (e.g., 1.0). Adds SMI_WITH_DOT type to maintain this. BUG=chromium:638134 Committed: https://crrev.com/477495c886f09d21487482b687e9ffbf8332f453 Cr-Commit-Position: refs/heads/master@{#38698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M src/ast/ast-value-factory.h View 5 chunks +15 lines, -16 lines 0 comments Download
M src/ast/ast-value-factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PrimitiveReturnStatements.golden View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/UnaryOperators.golden View 1 chunk +1 line, -2 lines 0 comments Download
A test/mjsunit/regress/regress-638134.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rmcilroy
Adam, PTAL, thanks.
4 years, 4 months ago (2016-08-16 21:36:21 UTC) #2
rmcilroy
On 2016/08/16 21:36:21, rmcilroy wrote: > Adam, PTAL, thanks. Friendly ping?
4 years, 4 months ago (2016-08-17 22:07:59 UTC) #3
adamk
lgtm
4 years, 4 months ago (2016-08-18 02:01:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248693005/1
4 years, 4 months ago (2016-08-18 07:48:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 08:15:38 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:15:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/477495c886f09d21487482b687e9ffbf8332f453
Cr-Commit-Position: refs/heads/master@{#38698}

Powered by Google App Engine
This is Rietveld 408576698