Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2248693004: SkLiteDL: remove freelisting, add reset() and SKLITEDL_PAGE knob. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkLiteDL: remove freelisting, add reset() and SKLITEDL_PAGE knob. We think Android can cache these better than a global freelist allows. This removes the freelisting but adds reset() to allow reuse. I took the opportunity to abstract 4096 as a define SKLITEDL_PAGE. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2248693004 Committed: https://skia.googlesource.com/skia/+/883c8efae702462fa28e7ce4f17199bbfa1ce360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -94 lines) Patch
M include/core/SkMath.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkGraphics.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M src/core/SkLiteDL.h View 3 chunks +2 lines, -9 lines 0 comments Download
M src/core/SkLiteDL.cpp View 3 chunks +19 lines, -51 lines 0 comments Download
M tests/SkLiteDLTest.cpp View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mtklein_C
4 years, 4 months ago (2016-08-16 16:01:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248693004/1
4 years, 4 months ago (2016-08-16 16:01:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/12650)
4 years, 4 months ago (2016-08-16 16:03:20 UTC) #7
djsollen
lgtm
4 years, 4 months ago (2016-08-16 16:32:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248693004/1
4 years, 4 months ago (2016-08-16 16:32:42 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 16:36:21 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/883c8efae702462fa28e7ce4f17199bbfa1ce360

Powered by Google App Engine
This is Rietveld 408576698