Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2248693003: Take style into account when matching fonts

Created:
4 years, 4 months ago by Ilya Kulshin
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Take style into account when matching fonts BUG=635932

Patch Set 1 #

Patch Set 2 : Do the style match before considering the user's standard font. #

Patch Set 3 : Fix ligatures-linebreak tests (test was specifying generic sans-serif as an acceptable font) #

Patch Set 4 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/text/font-ligatures-linebreak.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/font-ligatures-linebreak-word.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontFallbackList.cpp View 1 2 3 2 chunks +45 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (14 generated)
Ilya Kulshin
The CQ bit was checked by kulshin@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-16 01:07:14 UTC) #1
Ilya Kulshin
The CQ bit was unchecked by kulshin@chromium.org
4 years, 4 months ago (2016-08-16 01:07:35 UTC) #2
Ilya Kulshin
The CQ bit was checked by kulshin@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-16 01:08:45 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248693003/1
4 years, 4 months ago (2016-08-16 01:09:08 UTC) #4
Ilya Kulshin
The CQ bit was checked by kulshin@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-16 02:50:05 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248693003/20001
4 years, 4 months ago (2016-08-16 02:50:25 UTC) #6
Ilya Kulshin
The CQ bit was unchecked by kulshin@chromium.org
4 years, 4 months ago (2016-08-16 02:51:42 UTC) #7
Ilya Kulshin
The CQ bit was checked by kulshin@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-16 22:42:18 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248693003/40001
4 years, 4 months ago (2016-08-16 22:42:44 UTC) #9
Ilya Kulshin
The CQ bit was unchecked by kulshin@chromium.org
4 years, 4 months ago (2016-08-16 22:43:07 UTC) #10
Ilya Kulshin
The CQ bit was checked by kulshin@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-16 22:43:24 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2248693003/40001
4 years, 4 months ago (2016-08-16 22:43:57 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-17 00:50:22 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 00:50:24 UTC) #14 
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698