chrome/browser/resources/settings/site_settings/site_data_details_dialog.js - Issue 2248683006: Site Settings Desktop: Implement individual cookie removal and RemoveAll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

Issue 2248683006: Site Settings Desktop: Implement individual cookie removal and RemoveAll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_data.js ('k') | chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

index 9af5239d8fbdb3a63788baa984b6aa06bb2e2b79..577664adbf2c88e965880cb6af3ddf8f54ddeb88 100644

--- a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

+++ b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

@@ -121,10 +121,14 @@ Polymer({

site.addCookieData(root, node);

- /** @private */

+ /**

+ * Called when a single item has been removed.

+ * @param {!CookieRemovePacket} args The details about what to remove.

+ * @private

+ */

onTreeItemRemoved_: function(args) {

this.entries_ = this.site_.getCookieList();

- if (args[0] == this.site_.data_.id || this.entries_.length == 0) {

+ if (args.id == this.site_.data_.id || this.entries_.length == 0) {

this.$.dialog.close();

return;

}