Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: src/source-position-table.h

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | src/source-position-table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/source-position-table.h
diff --git a/src/source-position-table.h b/src/source-position-table.h
index c85d2371bfe1f0b023d1e5684d955102401e5ad1..76ae4a07591bce58611af3f297e5968090dfb1b4 100644
--- a/src/source-position-table.h
+++ b/src/source-position-table.h
@@ -34,29 +34,25 @@ class SourcePositionTableBuilder {
public:
enum RecordingMode { OMIT_SOURCE_POSITIONS, RECORD_SOURCE_POSITIONS };
- SourcePositionTableBuilder(Isolate* isolate, Zone* zone,
+ SourcePositionTableBuilder(Zone* zone,
RecordingMode mode = RECORD_SOURCE_POSITIONS);
- void EndJitLogging(AbstractCode* code);
-
void AddPosition(size_t code_offset, int source_position, bool is_statement);
- Handle<ByteArray> ToSourcePositionTable();
+
+ Handle<ByteArray> ToSourcePositionTable(Isolate* isolate,
+ Handle<AbstractCode> code);
private:
void AddEntry(const PositionTableEntry& entry);
inline bool Omit() const { return mode_ == OMIT_SOURCE_POSITIONS; }
- Isolate* isolate_;
RecordingMode mode_;
ZoneVector<byte> bytes_;
#ifdef ENABLE_SLOW_DCHECKS
ZoneVector<PositionTableEntry> raw_entries_;
#endif
PositionTableEntry previous_; // Previously written entry, to compute delta.
- // Currently jit_handler_data_ is used to store JITHandler-specific data
- // over the lifetime of a SourcePositionTableBuilder.
- void* jit_handler_data_;
};
class SourcePositionTableIterator {
« no previous file with comments | « src/objects-inl.h ('k') | src/source-position-table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698