Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/log.h

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-array-writer.cc ('k') | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index 6e5c170d6dcb1b8daa17d266888a8e244b3eab7e..a05b187282c1170e6e600672738aefd35c5be952 100644
--- a/src/log.h
+++ b/src/log.h
@@ -179,20 +179,9 @@ class Logger : public CodeEventListener {
void RegExpCodeCreateEvent(AbstractCode* code, String* source);
// Emits a code move event.
void CodeMoveEvent(AbstractCode* from, Address to);
- // Emits a code line info add event with Postion type.
- void CodeLinePosInfoAddPositionEvent(void* jit_handler_data,
- int pc_offset,
- int position);
- // Emits a code line info add event with StatementPostion type.
- void CodeLinePosInfoAddStatementPositionEvent(void* jit_handler_data,
- int pc_offset,
- int position);
- // Emits a code line info start to record event
- void CodeStartLinePosInfoRecordEvent(void** jit_handler_data_out);
- // Emits a code line info finish record event.
- // It's the callee's responsibility to dispose the parameter jit_handler_data.
- void CodeEndLinePosInfoRecordEvent(AbstractCode* code,
- void* jit_handler_data);
+ // Emits a code line info record event.
+ void CodeLinePosInfoRecordEvent(AbstractCode* code,
+ ByteArray* source_position_table);
void SharedFunctionInfoMoveEvent(Address from, Address to);
@@ -346,7 +335,6 @@ class Logger : public CodeEventListener {
base::ElapsedTimer timer_;
friend class CpuProfiler;
- friend class SourcePositionTableBuilder;
};
#define TIMER_EVENTS_LIST(V) \
« no previous file with comments | « src/interpreter/bytecode-array-writer.cc ('k') | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698