Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: src/full-codegen/full-codegen.cc

Issue 2248673002: Avoid accessing Isolate in source position logging. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/interpreter/bytecode-array-writer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/full-codegen/full-codegen.h" 5 #include "src/full-codegen/full-codegen.h"
6 6
7 #include "src/ast/ast-numbering.h" 7 #include "src/ast/ast-numbering.h"
8 #include "src/ast/ast.h" 8 #include "src/ast/ast.h"
9 #include "src/ast/prettyprinter.h" 9 #include "src/ast/prettyprinter.h"
10 #include "src/ast/scopes.h" 10 #include "src/ast/scopes.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 CodeGenerator::MakeCodeEpilogue(&masm, nullptr, info, masm.CodeObject()); 59 CodeGenerator::MakeCodeEpilogue(&masm, nullptr, info, masm.CodeObject());
60 cgen.PopulateDeoptimizationData(code); 60 cgen.PopulateDeoptimizationData(code);
61 cgen.PopulateTypeFeedbackInfo(code); 61 cgen.PopulateTypeFeedbackInfo(code);
62 cgen.PopulateHandlerTable(code); 62 cgen.PopulateHandlerTable(code);
63 code->set_has_deoptimization_support(info->HasDeoptimizationSupport()); 63 code->set_has_deoptimization_support(info->HasDeoptimizationSupport());
64 code->set_has_reloc_info_for_serialization(info->will_serialize()); 64 code->set_has_reloc_info_for_serialization(info->will_serialize());
65 code->set_allow_osr_at_loop_nesting_level(0); 65 code->set_allow_osr_at_loop_nesting_level(0);
66 code->set_profiler_ticks(0); 66 code->set_profiler_ticks(0);
67 code->set_back_edge_table_offset(table_offset); 67 code->set_back_edge_table_offset(table_offset);
68 Handle<ByteArray> source_positions = 68 Handle<ByteArray> source_positions =
69 cgen.source_position_table_builder_.ToSourcePositionTable(); 69 cgen.source_position_table_builder_.ToSourcePositionTable(
70 isolate, Handle<AbstractCode>::cast(code));
70 code->set_source_position_table(*source_positions); 71 code->set_source_position_table(*source_positions);
71 cgen.source_position_table_builder_.EndJitLogging(AbstractCode::cast(*code));
72 CodeGenerator::PrintCode(code, info); 72 CodeGenerator::PrintCode(code, info);
73 info->SetCode(code); 73 info->SetCode(code);
74 74
75 #ifdef DEBUG 75 #ifdef DEBUG
76 // Check that no context-specific object has been embedded. 76 // Check that no context-specific object has been embedded.
77 code->VerifyEmbeddedObjects(Code::kNoContextSpecificPointers); 77 code->VerifyEmbeddedObjects(Code::kNoContextSpecificPointers);
78 #endif // DEBUG 78 #endif // DEBUG
79 return true; 79 return true;
80 } 80 }
81 81
(...skipping 1856 matching lines...) Expand 10 before | Expand all | Expand 10 after
1938 return var->scope()->is_nonlinear() || 1938 return var->scope()->is_nonlinear() ||
1939 var->initializer_position() >= proxy->position(); 1939 var->initializer_position() >= proxy->position();
1940 } 1940 }
1941 1941
1942 1942
1943 #undef __ 1943 #undef __
1944 1944
1945 1945
1946 } // namespace internal 1946 } // namespace internal
1947 } // namespace v8 1947 } // namespace v8
OLDNEW
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/interpreter/bytecode-array-writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698